diff options
| author | Jonas Smedegaard <dr@jones.dk> | 2013-03-08 19:29:38 +0100 |
|---|---|---|
| committer | Daniel Kahn Gillmor <dkg@fifthhorseman.net> | 2013-03-13 02:13:38 -0400 |
| commit | 0c081207c94b0ed338a704fafac10166ce98bba7 (patch) | |
| tree | ef791d7ea68fd6a51074156bbac97d9c6b5a398a /src/share/ma/update_users | |
| parent | ed10318d3760b56e57d5e1bef04ab57761ab8bd1 (diff) | |
Pass only single commands through su wrapper
It is a healthy coding practice to keep each argument separate when
executing system calls, i.e. quote each variable separately instead of
relying on whitespace to indicate argument separation.
Quoting shell-inside-shell is tricky to do right, and gets trickier when
more than a single command is wrapped together.
This patch simplifies convoluted shell calls to contain only one command
each.
Example:
before: bash -c ". .../common; process_authorized_user_ids -"
after: bash -c ".../common process_authorized_user_ids -"
Diffstat (limited to 'src/share/ma/update_users')
| -rw-r--r-- | src/share/ma/update_users | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/share/ma/update_users b/src/share/ma/update_users index a70d000..85813cd 100644 --- a/src/share/ma/update_users +++ b/src/share/ma/update_users @@ -79,7 +79,7 @@ for uname in $unames ; do # process authorized_user_ids file, as monkeysphere user su_monkeysphere_user \ - ". ${SYSSHAREDIR}/common; STRICT_MODES='$STRICT_MODES' process_authorized_user_ids -" \ + "/usr/bin/env STRICT_MODES='$STRICT_MODES' ${SYSSHAREDIR}/common process_authorized_user_ids -" \ < "$authorizedUserIDs" \ > "$tmpAuthorizedKeys" |