summaryrefslogtreecommitdiff
path: root/doc/bugs/pagestats_plugin_broken.mdwn
blob: 0ae74b4eeae16b64fe7564d2cfbe56535824f79f (plain)

Since at least version 2.0 (and certainly a few version before), it seems that the pagestats plugin is broken : each matched page has a count of 2. This is also (of course) producing flat tag cloud.

My perl knowledge is very limited, but the call :

my @bl = IkiWiki::backlinks($page);
$counts{$page} = scalar(@bl);

return allways 2, which seems to me "obvious", because the backlinks() function is returning two array of links...

Patch is :

--- /usr/share/perl5/IkiWiki/Plugin/pagestats.pm        2007-04-27 04:33:43.000000000 +0200
+++ ./pagestats.pm      2007-05-12 16:47:14.000000000 +0200
@@ -36,7 +36,7 @@
                if (pagespec_match($page, $params{pages}, location => $params{page})) {
                        use IkiWiki::Render;
                        my @bl = IkiWiki::backlinks($page);
-                       $counts{$page} = scalar(@bl);
+                       $counts{$page} = scalar(@{$bl[0]})+scalar(@{$bl[1]});
                        $max = $counts{$page} if $counts{$page} > $max;
                }
        }

--[[users/hb]]

thanks, [[done]] --[[Joey]]