summaryrefslogtreecommitdiff
path: root/doc/bugs/pagespec_parsing_chokes_on_function__40____41__.mdwn
blob: a2eba694cfe9682cc975e3247d1cb0e36c262047 (plain)

The pagespec regexes don't allow functions with no arguments.

IkiWiki.pm, around line 1035:

command(params) of course might be just command(). (See conditional.pm: match_included.) Trying to feed ikiwiki a pagespec without params will get you instead:

IkiWiki::PageSpec::match_glob($page, q{function}, @params) ( )

Which is completely not desired. The second + on that line should be a *.

None of the builtin pagespecs "work" with no parameters, so it's hard to write a unit test for this. But can we at least write a helpful note in case the user is given to rebuilding the wiki by hand. --Ethan

Thanks, [[done]] --[[Joey]]

Note that the printing of the error isn't needed though. pagespec_match() returns an IkiWiki::FailReason object if parsing fails, and its caller can use that as desired to print the error.