summaryrefslogtreecommitdiff
path: root/doc/bugs/bzr_plugin_does_not_define_rcs__95__diff.mdwn
blob: ece919f0923dcd34fdfa5088e6917f5f038c63a9 (plain)

The bzr plugin does not seem to define the rcs_diff subroutine. I got the follow error after enabling recentchangesdiff:

"Undefined subroutine &IkiWiki::Plugin::bzr::rcs_diff called at /usr/share/perl5/IkiWiki.pm line 1590."

Grepping to verify absence of rcs_diff:

$ grep rcs_diff /usr/share/perl5/IkiWiki/Plugin/{git,bzr}.pm
/usr/share/perl5/IkiWiki/Plugin/git.pm:	hook(type => "rcs", id => "rcs_diff", call => \&rcs_diff);
/usr/share/perl5/IkiWiki/Plugin/git.pm:sub rcs_diff ($) {
/usr/share/perl5/IkiWiki/Plugin/bzr.pm:	hook(type => "rcs", id => "rcs_diff", call => \&rcs_diff);

I've added the minimal stub needed to avoid the crash, but for recentchangesdiff to work, someone needs to implement rcs_diff for bzr. This should be trivial if you know and use bzr. The function is passed as a parameter the revno of interest and just needs to ask bzr for the diff between that and the previous version. --[[Joey]]