doc/bugs/Problem_with_toc.pm_plug-in.mdwn



The toc.pm plug-in currently renders empty 'a' tag elements. This seems to confuse at least Firefox, possibly others. The result is that the following text is rendered as an anchor (visible if you style 'a' elements in a different color).
Here is a patch for toc.pm for producing non-empty 'a' elements.

Thanks for the patch, but I already fixed this in 2.4 using a different
approach. I think your patch is slightly broken, an anchor tag isn't
really meant to enclose all the html it anchors to, but just be stuck in
front of it. --[[Joey]] [[tag done]]

--- IkiWiki/Plugin/toc.pm.orig	Thu Jun  7 11:53:53 2007
+++ IkiWiki/Plugin/toc.pm	Thu Jun  7 13:00:00 2007
@@ -47,7 +47,7 @@ sub format (@) { #{{{
 		if ($tagname =~ /^h(\d+)$/i) {
 			my $level=$1;
 			my $anchor="index".++$anchors{$level}."h$level";
-			$page.="$text<a name=\"$anchor\" />";
+			$page.="$text<a name=\"$anchor\">";
 	
 			# Take the first header level seen as the topmost level,
 			# even if there are higher levels seen later on.
@@ -90,6 +90,16 @@ sub format (@) { #{{{
 					"</a>\n";
 				$p->handler(text => undef);
 			}, "dtext");
+		}
+		else {
+			$page.=$text;
+		}
+	}, "tagname, text");
+	$p->handler(end => sub {
+		my $tagname=shift;
+		my $text=shift;
+		if ($tagname =~ /^h(\d+)$/i) {
+			$page.="</a>$text";
 		}
 		else {
 			$page.=$text;