summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--doc/todo/Raw_view_link.mdwn5
-rw-r--r--doc/todo/source_link.mdwn15
2 files changed, 18 insertions, 2 deletions
diff --git a/doc/todo/Raw_view_link.mdwn b/doc/todo/Raw_view_link.mdwn
index 8f412fd09..fd64074c2 100644
--- a/doc/todo/Raw_view_link.mdwn
+++ b/doc/todo/Raw_view_link.mdwn
@@ -10,7 +10,8 @@ The configuration setting for Mercurial could be something like this:
> Not that I'm opposed to the idea of a plugin that adds a Raw link
> --[[Joey]]
->> [[todo/source_link]] does this via the CGI instead of delegating
->> to gitweb/etc. --[[smcv]]
+>> In [[todo/source_link]], Will does this via the CGI instead of delegating
+>> to gitweb/etc. I think Will's patch is a good approach, and have improved
+>> on it a bit in a git branch.
[[!tag wishlist]]
diff --git a/doc/todo/source_link.mdwn b/doc/todo/source_link.mdwn
index 9d9ec9697..962e099a6 100644
--- a/doc/todo/source_link.mdwn
+++ b/doc/todo/source_link.mdwn
@@ -9,6 +9,21 @@ I just implemented this. There is one [[patch]] to the default page template, a
> by loading the index with IkiWiki::loadindex, like [[plugins/goto]] does?
> --[[smcv]]
+[[!template id=gitbranch branch=smcv/getsource
+ author="[[Will]]/[[smcv]]"]]
+
+>> I've applied the patch below in a git branch, fixed my earlier criticism,
+>> and also fixed a couple of other issues I noticed:
+>>
+>> * missing pages could be presented better as a real 404 page
+>> * the default Content-type should probably be UTF-8 since the rest of
+>> IkiWiki tends to assume that
+>> * emitting attachments (images, etc.) as text/plain isn't going to work :-)
+>>
+>> Any opinions on my branch? I think it's ready for merge, if Joey approves.
+>>
+>> --[[smcv]]
+
----
diff --git a/templates/page.tmpl b/templates/page.tmpl