summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2011-04-30 17:02:05 -0400
committerJoey Hess <joey@kitenet.net>2011-04-30 17:02:05 -0400
commite9cdb2505dc40a85a66aae0045e144f091e8dc15 (patch)
tree406b20e0131ec32842e68733b1a32c199ec2c997 /doc
parent86aaa4223c80e438190abef447d2c9101c87ea66 (diff)
initial patch review; 2 possible bugs
Diffstat (limited to 'doc')
-rw-r--r--doc/todo/nested_preprocessor_directives.mdwn13
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/todo/nested_preprocessor_directives.mdwn b/doc/todo/nested_preprocessor_directives.mdwn
index f38f94444..da7621a39 100644
--- a/doc/todo/nested_preprocessor_directives.mdwn
+++ b/doc/todo/nested_preprocessor_directives.mdwn
@@ -32,3 +32,16 @@ nesting, a new syntax would be needed. Maybe something xml-like?
>> once I satisfy myself it doesn't blow up in any edge cases.
>> (It also adds triple single quotes as a third, distinct type of quotes,
>> which feels a bit redundant given the here docs.) --[[Joey]]
+>>
+>> Hmm, that patch changes a `m///sgx` to a `m///msgx`. Meaning
+>> that any '^' or '$' inside the regexp will change behavior from matching
+>> the start/end of string to matching the start/end of individual lines
+>> within the string. And there is one legacy '$' which must then
+>> change behavior; the "delimiter to next param".
+>>
+>> So, I'm not sure what behavior that will cause, but I suspect it will
+>> be a bug. Unless the `\s+|$' already stops matching at a newline within
+>> the string like it's whitespace. That needs more alalysis.
+>>
+>> Also, the patch seems incomplete, only patching the first regexp
+>> but not the other two in the same function, which also are quoting-aware. --[[Joey]]