summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2010-10-11 11:41:40 -0400
committerJoey Hess <joey@kitenet.net>2010-10-11 11:41:40 -0400
commitc321f5406b29e29b6ff61ab9e291a24d68e9d824 (patch)
tree76dacdc75fb0b2543367e6dcc200284cd2a0e0a1 /doc
parentcfbd272c8bdbb96b6e92449f4d940fb2b72aa651 (diff)
parent2ef899d9f94768d714b81ff5bc157e5f2c521395 (diff)
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Diffstat (limited to 'doc')
-rw-r--r--doc/bugs/class_parameter_of_img_directive_behave_not_as_documented.mdwn29
1 files changed, 29 insertions, 0 deletions
diff --git a/doc/bugs/class_parameter_of_img_directive_behave_not_as_documented.mdwn b/doc/bugs/class_parameter_of_img_directive_behave_not_as_documented.mdwn
new file mode 100644
index 000000000..10ba15066
--- /dev/null
+++ b/doc/bugs/class_parameter_of_img_directive_behave_not_as_documented.mdwn
@@ -0,0 +1,29 @@
+On [[ikiwiki/directive/img/]] I read that
+
+> You can also pass alt, title, class, align, id, hspace, and vspace
+> parameters. These are passed through unchanged to the html img tag.
+
+but when I pass `class="myclass"` to an img directive, I obtain
+
+ <img class="myclass img" ...
+
+I found that this behaviour was added in commit f6db10d:
+
+> img: Add a margin around images displayed by this directive.
+>
+> Particularly important for floating images, which could before be placed
+> uncomfortably close to text.
+
+which adds to img.pm:
+
+ if (exists $params{class}) {
+ $params{class}.=" img";
+ }
+ else {
+ $params{class}="img";
+ }
+
+I would prefer if the `img` class were only added if no class attribute is
+passed.
+
+If you keep the current behaviour, please document it.