summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2011-02-22 17:37:38 -0400
committerJoey Hess <joey@kitenet.net>2011-02-22 17:37:38 -0400
commit8345139315e7611af118f9ee86b39a6279385235 (patch)
treefd4c97446a8ee61ce0c54a7e0b85452f8fff7ec5 /doc
parentb2a8f0f5b43cf5c5126c800be999cbda5e49bc54 (diff)
review other 2
Diffstat (limited to 'doc')
-rw-r--r--doc/todo/feed_enhancements_for_inline_pages.mdwn7
1 files changed, 7 insertions, 0 deletions
diff --git a/doc/todo/feed_enhancements_for_inline_pages.mdwn b/doc/todo/feed_enhancements_for_inline_pages.mdwn
index 46b6a2512..ec7c8c668 100644
--- a/doc/todo/feed_enhancements_for_inline_pages.mdwn
+++ b/doc/todo/feed_enhancements_for_inline_pages.mdwn
@@ -56,7 +56,14 @@ requirement described anywhere. Rather than restricting the user input,
I propose a patch that prevents double slashes from appearing in links
created by `urlto()` by fixing the routine itself.
+> If this is fixed I would rather not put the overhead of fixing it in
+> every call to `urlto`. And I'm not sure this is a comprehensive
+> fix to every problem a trailing slash in the url could cause. --[[Joey]]
+
The inline plugin is also updated (in a separate patch) to use `urlto()`
rather than hand-coding the feed urls. You might want to keep this
change even if you discard the urlto patch.
+> IIRC, I was missing a proof that this always resulted in identical urls,
+> which is necessary to prevent flooding. I need such a proof before I can
+> apply that. --[[Joey]]