diff options
| author | Joey Hess <joey@kitenet.net> | 2010-05-17 17:13:53 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2010-05-17 17:13:53 -0400 |
| commit | 2b1bc9c7297dc4bf36f4fc91205ad13eaf1513ca (patch) | |
| tree | 578aa7d00eb869cbacf2a7f85eb8c2bf2467e398 /doc | |
| parent | facc77e10925301575b46d26e031c9f6914edafb (diff) | |
review
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/todo/allow_displaying_number_of_comments.mdwn | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/doc/todo/allow_displaying_number_of_comments.mdwn b/doc/todo/allow_displaying_number_of_comments.mdwn index 8e479bc85..7e8802210 100644 --- a/doc/todo/allow_displaying_number_of_comments.mdwn +++ b/doc/todo/allow_displaying_number_of_comments.mdwn @@ -5,5 +5,23 @@ bits of) a more usual webforum. Please review... and pull :) -- [[intrigeri]] + +> How is having this variable for showing a count of the comments +> better (or more forum-ish) than the COMMENTSLINK variable which +> includes a count and a link to the comments, and is already displayed +> in inlinepage.tmpl? +> +> `num_comments` will never return undef. +> +> I see no need to add a second pagetemplate hook. +> The existing one can be added to. Probably inside its `if ($shown)` +> block. +> +> It may also be a good idea to either combine the calls to `num_comments` +> used for this and for the commentslink, +> or to memoize it. I'm thinking generally memoizing it may be a good idea +> since the comments for a page will typically be counted twice when it's +> inlined. +> --[[Joey]] [[patch]] |