summaryrefslogtreecommitdiff
path: root/doc/plugins
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2009-09-11 14:44:32 -0400
committerJoey Hess <joey@gnu.kitenet.net>2009-09-11 14:44:32 -0400
commit412a4dd62ade18f5e057ff3324321188245a542e (patch)
tree2bafe8883ce25a2ed2a480e2a9ca8611ec5d9711 /doc/plugins
parent06c712a7f0c75da344da43cd6030924b856a9439 (diff)
review
Diffstat (limited to 'doc/plugins')
-rw-r--r--doc/plugins/contrib/rsync/discussion.mdwn14
1 files changed, 14 insertions, 0 deletions
diff --git a/doc/plugins/contrib/rsync/discussion.mdwn b/doc/plugins/contrib/rsync/discussion.mdwn
index 20c04af0f..9b4184e5f 100644
--- a/doc/plugins/contrib/rsync/discussion.mdwn
+++ b/doc/plugins/contrib/rsync/discussion.mdwn
@@ -46,3 +46,17 @@ The wiki now lives on (1), and clicking "edit" just works. --[[schmonz]]
>> This plugin is definitely still useful for projects not able to use
>> a DVCS (of which I've got at least one other), and possibly for
>> other uses not yet imagined. ;-) --[[schmonz]]
+
+----
+
+Revew: --[[Joey]]
+
+* I think it should not throw an error if no command is set. Just don't do anything.
+* If the rsync fails, it currently errors out, which will probably also leave
+ the wiki in a broken state, since ikiwiki will not get a chance to save
+ its state. This seems fragile; what if the laptop is offline, or the
+ server is down, etc. Maybe it should just warn if the rsync fails?
+* Is a new hook really needed? The savestate hook runs at a similar time;
+ only issue with it is that it is run even when ikiwiki has not
+ rendered any updated pages. Bah, I think you do need the new hook, how
+ annoying..