diff options
| author | Amitai Schlair <schmonz@magnetic-babysitter.(none)> | 2009-09-11 17:03:41 -0400 |
|---|---|---|
| committer | Amitai Schlair <schmonz@magnetic-babysitter.(none)> | 2009-09-11 17:03:41 -0400 |
| commit | 5a627f1853b4edcbe38dabcfca37fde477572ef5 (patch) | |
| tree | c33891232176d2321fc3f7f2abfa63888af82f47 /doc/plugins/contrib/rsync/discussion.mdwn | |
| parent | a69d628b2cc15779a23c3d5ca1b27f2bc2dad619 (diff) | |
| parent | 1846bd30611c69e223e1bb8d3ff5d4b9444dd51c (diff) | |
Merge branch 'master' of git://github.com/joeyh/ikiwiki
Diffstat (limited to 'doc/plugins/contrib/rsync/discussion.mdwn')
| -rw-r--r-- | doc/plugins/contrib/rsync/discussion.mdwn | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/doc/plugins/contrib/rsync/discussion.mdwn b/doc/plugins/contrib/rsync/discussion.mdwn index 20c04af0f..9b4184e5f 100644 --- a/doc/plugins/contrib/rsync/discussion.mdwn +++ b/doc/plugins/contrib/rsync/discussion.mdwn @@ -46,3 +46,17 @@ The wiki now lives on (1), and clicking "edit" just works. --[[schmonz]] >> This plugin is definitely still useful for projects not able to use >> a DVCS (of which I've got at least one other), and possibly for >> other uses not yet imagined. ;-) --[[schmonz]] + +---- + +Revew: --[[Joey]] + +* I think it should not throw an error if no command is set. Just don't do anything. +* If the rsync fails, it currently errors out, which will probably also leave + the wiki in a broken state, since ikiwiki will not get a chance to save + its state. This seems fragile; what if the laptop is offline, or the + server is down, etc. Maybe it should just warn if the rsync fails? +* Is a new hook really needed? The savestate hook runs at a similar time; + only issue with it is that it is run even when ikiwiki has not + rendered any updated pages. Bah, I think you do need the new hook, how + annoying.. |