summaryrefslogtreecommitdiff
path: root/doc/plugins/contrib/cvs
diff options
context:
space:
mode:
authorAmitai Schlair <schmonz@magnetic-babysitter.Ativa>2009-09-09 22:36:23 -0400
committerAmitai Schlair <schmonz@magnetic-babysitter.Ativa>2009-09-09 22:36:23 -0400
commit1b4c3fb551754cc70abd7a18871a79d79ac3cb5b (patch)
treecbf36d190aa0042e642bd083dbff99bfc2a3cb56 /doc/plugins/contrib/cvs
parent2a99ebf2766a08f8d68a82255d1518ecac73ec84 (diff)
note refactored wrapper tweakulation
Diffstat (limited to 'doc/plugins/contrib/cvs')
-rw-r--r--doc/plugins/contrib/cvs/discussion.mdwn16
1 files changed, 16 insertions, 0 deletions
diff --git a/doc/plugins/contrib/cvs/discussion.mdwn b/doc/plugins/contrib/cvs/discussion.mdwn
index 1f0ce0102..155a2289d 100644
--- a/doc/plugins/contrib/cvs/discussion.mdwn
+++ b/doc/plugins/contrib/cvs/discussion.mdwn
@@ -125,3 +125,19 @@ to pass to the command.
> Thanks for reading carefully. I've tested your suggestions and
> applied them on my branch. --[[schmonz]]
+
+----
+
+I've abstracted out CVS's involvement in the wrapper, adding a new
+"wrapperargcheck" hook to examine `argc/argv` and return success or
+failure (failure causes the wrapper to terminate) and implementing
+this hook in the plugin. In the non-CVS case, the check immediately
+returns success, so the added overhead is just a function call.
+
+Given how rarely anything should need to reach in and modify the
+wrapper -- I'd go so far as to say we shouldn't make it too easy
+-- I don't think it's worth the effort to try and design a more
+general-purpose way to do so. If and when some other problem thinks
+it wants to be solved by a new wrapper hook, it's easy enough to add
+one. Until then, I'd say it's more important to keep the wrapper as
+short and clear as possible. --[[schmonz]]