diff options
| author | Joey Hess <joey@kitenet.net> | 2010-11-29 13:28:28 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2010-11-29 13:28:28 -0400 |
| commit | a5120846cb6461616dce4d0042a4fd45211170e4 (patch) | |
| tree | 7cec2ccdbc641aa08ed1c3ca64f059afe4357229 /doc/bugs | |
| parent | b342d0960666804b595a105919e1288f6057a686 (diff) | |
rename: Fix to pass named parameters to rcs_commit
Diffstat (limited to 'doc/bugs')
| -rw-r--r-- | doc/bugs/git_commit_adds_files_that_were_not_tracked.mdwn | 7 | ||||
| -rw-r--r-- | doc/bugs/rename_fixup_not_attributed_to_author.mdwn | 3 |
2 files changed, 10 insertions, 0 deletions
diff --git a/doc/bugs/git_commit_adds_files_that_were_not_tracked.mdwn b/doc/bugs/git_commit_adds_files_that_were_not_tracked.mdwn index 1b6eeb2a5..829e80327 100644 --- a/doc/bugs/git_commit_adds_files_that_were_not_tracked.mdwn +++ b/doc/bugs/git_commit_adds_files_that_were_not_tracked.mdwn @@ -9,3 +9,10 @@ I'm unsure yet why the recentchanges files were being committed. Possibly because of the link fixup code run when renaming a page. --[[Joey]] > See also [[bugs/rename fixup not attributed to author]]. --[[smcv]] + +> Ok, there was a call to `rcs_commit` that was still using non-named +> parameters, which confused it thuroughly, and I think caused +> 'git add .' to be called. I've fixed that. +> +> I think there is still potential for the problem I described above to +> occur during a rename or possibly otherwise. --[[Joey]] diff --git a/doc/bugs/rename_fixup_not_attributed_to_author.mdwn b/doc/bugs/rename_fixup_not_attributed_to_author.mdwn index 3122307a2..bcfafac22 100644 --- a/doc/bugs/rename_fixup_not_attributed_to_author.mdwn +++ b/doc/bugs/rename_fixup_not_attributed_to_author.mdwn @@ -7,3 +7,6 @@ and didn't set a commit message. been committed, for which see [[bugs/git_commit_adds_files_that_were_not_tracked]].) --[[smcv]] + +> It was calling `rcs_commit` old-style, and so not passing the session +> object that is used to get the user's name. [[fixed|done]] --[[Joey]] |