diff options
author | intrigeri <intrigeri@boum.org> | 2010-12-22 12:54:18 +0100 |
---|---|---|
committer | intrigeri <intrigeri@boum.org> | 2010-12-22 12:54:18 +0100 |
commit | a8d733130e99c3b611605d2b3d0db9a9ca8f98f7 (patch) | |
tree | 38ed3efebfa1c1c93afa325e9a57ad7e50f415c0 /doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn | |
parent | 74055be78f46fd4997eee160a092fd7e117b6c45 (diff) | |
parent | fd6d4fda6a95f8318c33aed66c4fcf05aad72b86 (diff) |
Merge remote branch 'upstream/master' into prv/po
Diffstat (limited to 'doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn')
-rw-r--r-- | doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn | 27 |
1 files changed, 27 insertions, 0 deletions
diff --git a/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn b/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn new file mode 100644 index 000000000..9690b8b7b --- /dev/null +++ b/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn @@ -0,0 +1,27 @@ +The po plugin needs to be updated to match the urlto sub API and +signature changes. Else a wiki with the po plugin enabled cannot be +refreshed / rebuilt because of (correct) Perl errors. + +My po branch contains a fix. +--[[intrigeri]] + +> The commit looks sane to me, for what it's worth. Joey, please +> consider merging? --[[smcv]] + +Also, I fear the lack of any useful `$from` parameter might break some +l10n'd link niceness when using `po_link_to = current` but I have not +investigated this yet. +--[[intrigeri]] + +> If `urlto` is called without a second parameter, it means we need +> a URL valid from either the CGI URL or any page in the wiki, +> (so we'd previously have set the third parameter true), but we +> don't *necessarily* need an absolute URL - so return what you'd +> have returned if asked for an absolute URL, but looking like +> `/bugs/` rather than `http://ikiwiki.info/bugs/` if possible. +> +> It looks as though `beautify_urlpath` under `po_link_to = current`, +> and 3-argument `urlto`, aren't tested by `t/po.t` - perhaps you +> could add some test cases there? To test 3-argument `urlto` you'd +> need to add `$config{baseurl} = "http://example.com"` or +> something. --[[smcv]] |