summaryrefslogtreecommitdiff
path: root/doc/bugs/cutpaste.pm:_missing_filter_call.mdwn
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2010-09-18 12:58:41 -0400
committerJoey Hess <joey@kitenet.net>2010-09-18 12:58:41 -0400
commit4843ec6dd09f4d88fa05ce178abe9cc1fb52b3e7 (patch)
treee1ce67c690d8ae2e7fcdfe160906d9f716bab216 /doc/bugs/cutpaste.pm:_missing_filter_call.mdwn
parent96a8ea0ebbd93a8cc56222234d4a5815b30a3934 (diff)
parent65c5e24d364f491ace462beb06e2e3adb721b1e0 (diff)
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Diffstat (limited to 'doc/bugs/cutpaste.pm:_missing_filter_call.mdwn')
-rw-r--r--doc/bugs/cutpaste.pm:_missing_filter_call.mdwn23
1 files changed, 23 insertions, 0 deletions
diff --git a/doc/bugs/cutpaste.pm:_missing_filter_call.mdwn b/doc/bugs/cutpaste.pm:_missing_filter_call.mdwn
new file mode 100644
index 000000000..30bd52996
--- /dev/null
+++ b/doc/bugs/cutpaste.pm:_missing_filter_call.mdwn
@@ -0,0 +1,23 @@
+Consider this:
+
+ $ wget http://www.thomas.schwinge.homeip.net/tmp/cutpaste_filter.tar.bz2
+ $ wget http://www.thomas.schwinge.homeip.net/tmp/cutpaste_filter.patch
+
+ $ tar -xj < cutpaste_filter.tar.bz2
+ $ cd cutpaste_filter/
+ $ ./render_locally
+ $ find "$PWD".rendered/ -type f -print0 | xargs -0 grep -H -E 'FOO|BAR'
+ [notice one FOO in there]
+ $ rm -rf .ikiwiki "$PWD".rendered
+
+ $ cp /usr/share/perl5/IkiWiki/Plugin/cutpaste.pm .library/IkiWiki/Plugin/
+ $ patch -p0 < ../cutpaste_filter.patch
+ $ ./render_locally
+ $ find "$PWD".rendered/ -type f -print0 | xargs -0 grep -H -E 'FOO|BAR'
+ [correct; notice no more FOO]
+
+I guess this needs a general audit -- there are other places where `preprocess`
+is being doing without `filter`ing first, for example in the same file, `copy`
+function.
+
+--[[tschwinge]]