summaryrefslogtreecommitdiff
path: root/IkiWiki/Plugin
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2010-04-17 13:55:32 -0400
committerJoey Hess <joey@kitenet.net>2010-04-17 13:55:38 -0400
commit2f9504a10d87f6950325dcea2d8a1f5a5d3eefe4 (patch)
tree8a846c8f4434e66e211b174bed8fefd32bf4bd4c /IkiWiki/Plugin
parent9ff5174f1164cb2d31ff487a9c84d08559b81d39 (diff)
bzr: changelog and refactor
Diffstat (limited to 'IkiWiki/Plugin')
-rw-r--r--IkiWiki/Plugin/bzr.pm20
1 files changed, 8 insertions, 12 deletions
diff --git a/IkiWiki/Plugin/bzr.pm b/IkiWiki/Plugin/bzr.pm
index 3712302ce..e7c1b8d8e 100644
--- a/IkiWiki/Plugin/bzr.pm
+++ b/IkiWiki/Plugin/bzr.pm
@@ -286,8 +286,10 @@ sub rcs_diff ($) {
}
}
-sub extract_timestamp ($) {
- my ($out) = @_;
+sub extract_timestamp (@) {
+ # XXX filename passes through the shell here, should try to avoid
+ # that just in case
+ open (my $out, "@_ |");
my @log = bzr_log($out);
if (length @log < 1) {
@@ -297,28 +299,22 @@ sub extract_timestamp ($) {
eval q{use Date::Parse};
error($@) if $@;
- my $ctime = str2time($log[0]->{"timestamp"});
- return $ctime;
+ my $time = str2time($log[0]->{"timestamp"});
+ return $time;
}
sub rcs_getctime ($) {
my ($file) = @_;
- # XXX filename passes through the shell here, should try to avoid
- # that just in case
my @cmdline = ("bzr", "log", "--forward", "--limit", '1', "$config{srcdir}/$file");
- open (my $out, "@cmdline |");
- return extract_timestamp($out);
+ return extract_timestamp(@cmdline);
}
sub rcs_getmtime ($) {
my ($file) = @_;
- # XXX filename passes through the shell here, should try to avoid
- # that just in case
my @cmdline = ("bzr", "log", "--limit", '1', "$config{srcdir}/$file");
- open (my $out, "@cmdline |");
- return extract_timestamp($out);
+ return extract_timestamp(@cmdline);
}
1