summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2010-06-18 12:50:31 -0400
committerJoey Hess <joey@kitenet.net>2010-06-18 12:50:31 -0400
commitd5199424c5625a816a2a3204708905e76bfb71aa (patch)
tree55cb04717bb0fde539ed2b7e2f0042f1f3ccf76a
parent2797a659db82dd1a0021dacd005fa80212c41579 (diff)
avoid shelling
-rw-r--r--IkiWiki/Plugin/bzr.pm4
1 files changed, 1 insertions, 3 deletions
diff --git a/IkiWiki/Plugin/bzr.pm b/IkiWiki/Plugin/bzr.pm
index e7c1b8d8e..9bee0c4b2 100644
--- a/IkiWiki/Plugin/bzr.pm
+++ b/IkiWiki/Plugin/bzr.pm
@@ -287,9 +287,7 @@ sub rcs_diff ($) {
}
sub extract_timestamp (@) {
- # XXX filename passes through the shell here, should try to avoid
- # that just in case
- open (my $out, "@_ |");
+ open (my $out, "-|", @_);
my @log = bzr_log($out);
if (length @log < 1) {