summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2009-10-29 10:17:30 -0400
committerJoey Hess <joey@gnu.kitenet.net>2009-10-29 10:17:30 -0400
commitce785c87022842a53eda6a25088eb4299907f938 (patch)
treeb37132c2290a364ba20021f793b519ec361d68ed
parentae7591fd18e4d96666971b8f5707dafd62b8d1e2 (diff)
fix url encoding in redir
When redirecting to a page, ie, after editing, ensure that the url is uri-encoded. Most browsers other than MSIE don't care, but it's the right thing to do. The known failure case involved editing a page that had utf-8 in the name using MSIE.
-rw-r--r--IkiWiki/CGI.pm3
-rw-r--r--debian/changelog3
2 files changed, 5 insertions, 1 deletions
diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index 52cafade0..9277223f0 100644
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -40,7 +40,8 @@ sub showform ($$$$;@) {
sub redirect ($$) {
my $q=shift;
- my $url=shift;
+ eval q{use URI};
+ my $url=URI->new(shift);
if (! $config{w3mmode}) {
print $q->redirect($url);
}
diff --git a/debian/changelog b/debian/changelog
index f517111b3..11fdc993f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,9 @@ ikiwiki (3.20091024) UNRELEASED; urgency=low
* mdwn: Avoid trying to use multimarkdown if it is not installed.
* moderatedcomments: New plugin to allow comment moderation w/o relying
on blogspam.net.
+ * When redirecting to a page, ie, after editing, ensure that the
+ url is uri-encoded. Most browsers other than MSIE don't care, but it's
+ the right thing to do.
-- Joey Hess <joeyh@debian.org> Mon, 26 Oct 2009 11:53:32 -0400