summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorhttp://smcv.pseudorandom.co.uk/ <smcv@web>2010-10-09 12:48:47 +0000
committerJoey Hess <joey@kitenet.net>2010-10-09 12:48:47 +0000
commitbc8b61dae8faa0a654f3a5f2278cd1c66a2f44a3 (patch)
tree41175ef4803cdd6896e931af04cc6390a5987717
parent2852c6b0d5494b21695ebe39b172fc30d01d2600 (diff)
pseudo-review
-rw-r--r--doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn24
1 files changed, 24 insertions, 0 deletions
diff --git a/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn b/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn
index fb33f195c..484f85cbb 100644
--- a/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn
+++ b/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn
@@ -24,3 +24,27 @@ and decided this time it was really needed to implement this feature.
> Ping. --[[intrigeri]]
[[!tag patch]]
+
+>> (I'm not an ikiwiki committer, opinions may vary.)
+>>
+>> This would be easier to review if there weren't a million merges from
+>> master; perhaps either leave a branch as-is, or rebase it, or merge
+>> only at "significant" times like after a release?
+>>
+>> I believe Joey's main objection to complex $config entries is that
+>> it's not at all clear what [[plugins/websetup]] would do with them.
+>> Would something like this make a reasonable alternative?
+>>
+>> $config{mirrorlist} = ["nousedirs|file:///home/intrigeri/wiki",
+>> "usedirs|http://example.com/wiki", "http://example.net"];
+>>
+>> From how I understand tainting, this:
+>>
+>> $untainted{$_} = possibly_foolish_untaint($tainted->{$_})
+>>
+>> probably needs to untaint the key too:
+>>
+>> my $key = possibly_foolish_untaint($_);
+>> $untainted{$key} = possibly_foolish_untaint($tainted->{key});
+>>
+>> --[[smcv]]