diff options
| author | Joey Hess <joey@kodama.kitenet.net> | 2008-08-23 12:13:38 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kodama.kitenet.net> | 2008-08-23 12:13:38 -0400 |
| commit | bc0e09e6c894b4d81c9467ab28507ee407c58495 (patch) | |
| tree | 2a424cca3b18ffb193dd2200b261470dd93f2f44 | |
| parent | cc111c977796e6b6f387e94232150c5b098bb57d (diff) | |
problem with the patch
| -rw-r--r-- | doc/bugs/map_is_inconsistent_about_bare_directories.mdwn | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/doc/bugs/map_is_inconsistent_about_bare_directories.mdwn b/doc/bugs/map_is_inconsistent_about_bare_directories.mdwn index dc2479e73..c78a8c68e 100644 --- a/doc/bugs/map_is_inconsistent_about_bare_directories.mdwn +++ b/doc/bugs/map_is_inconsistent_about_bare_directories.mdwn @@ -76,6 +76,16 @@ One solution could also use the [[plugins/autoindex]] plugin to make sure that p Note: This patch adds items to a map while it is in a foreach loop over a sorted list of keys from that same map. Changing a map while iterating through it is normally problematic. I'm assuming the sort insulates the code from this - I do not need to iterate over any of the newly added elements. +> This patch causes a small bug in the case where the map includes pages in +> two subdirs, and does not explicitly include either subdir. In that case, +> the map is supposed to show both subdirs, but use special styling an no +> link for either. With the patch, which otherwise seems to work ok, some +> of the non-included subdirs are displayed as if included. (I +> assume because the loop you added does in fact include them..) +> +> Example of the problem: \[[!map pages="plugins/contrib/* or plugins/type/*"]] +> --[[Joey]] + diff --git a/IkiWiki/Plugin/map.pm b/IkiWiki/Plugin/map.pm index 5b6a843..16de45e 100644 --- a/IkiWiki/Plugin/map.pm |