diff options
| author | Joey Hess <joey@kitenet.net> | 2011-01-05 13:19:26 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2011-01-05 13:19:26 -0400 |
| commit | 841cc576db2bddf5c851520ab7592464ec0aa259 (patch) | |
| tree | 77cf25972e748b49c9cab8333e27f512f43e0493 | |
| parent | a3769c60017e262364804ebfc24bcd8b74ef5b6d (diff) | |
doesn't only affect preview
| -rw-r--r-- | doc/bugs/preview_base_url_should_be_absolute.mdwn | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/bugs/preview_base_url_should_be_absolute.mdwn b/doc/bugs/preview_base_url_should_be_absolute.mdwn index 86575eed9..5391d39d6 100644 --- a/doc/bugs/preview_base_url_should_be_absolute.mdwn +++ b/doc/bugs/preview_base_url_should_be_absolute.mdwn @@ -24,3 +24,16 @@ git|http://git.oblomov.eu/ikiwiki]]. >> `CGI::url` uses `REQUEST_URI`. So it could be used, but I don't see >> how to get from the `CGI::url` to an url to the page that is being >> edited. --[[Joey]] +>>> (The right rune seems to be: `URI->new_abs(urlto($params{page}), $cgi->url))` --[[Joey]] + +--- + +Update: This bug is worse than it first appeared, and does not only affect +previewing. The cgi always has a `<base>` url, and it's always relative, +and that can break various links etc. For example, when the 404 plugin +displays a missing page, it has a Recentchanges link, which would be broken +if the cgi was in an unusual place. + +`misctemplate` needs to *always* set an absolute baseurl. Which is a problem, +since `misctemplate` is not currently passed a cgi object from which to +construct one. --[[Joey]] |