diff options
| author | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2007-07-28 20:59:49 +0000 |
|---|---|---|
| committer | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2007-07-28 20:59:49 +0000 |
| commit | 80d4d1d26de5da6416793a93d14c62d44ca064b2 (patch) | |
| tree | 162501f2a305aedeaf9f709b9997532d3c5671ee | |
| parent | f9ad5710144c592cfae0d3a358cdb59bcd6bac51 (diff) | |
no, it's fixed after all..
| -rw-r--r-- | doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn b/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn index d3629f840..1ec3e32bc 100644 --- a/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn +++ b/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn @@ -17,11 +17,10 @@ It also generates image URLs relative to the page being rendered, which means th >> the same, and the patch is still needed for making the graphviz >> plug-in work in preview mode here. ->>> You're right, it doesn't preview properly. However, your patch doesn't ->>> really fix it, since it only makes it show any old files that are lying ->>> around, and not a current one updated for the current page. Fixing it ->>> really right calls for embedding the file in a data uri in the preview ->>> page, as the sparkline plugin does. --[[Joey]] +>>> No, the relevant code is just above the bit you patched. Notice that in +>>> preview mode, it returns an img tag with the graphviz drawing embedded +>>> in it, using base64 encoding. Unless you can show me why that doesn't +>>> work, I still think this bug is done. --[[Joey]] >> Here is an updated patch againt ikiwiki-2.5: |