summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Gammie <peteg42@gmail.com>2010-10-01 14:08:07 +1000
committerPeter Gammie <peteg42@gmail.com>2010-10-01 14:08:07 +1000
commit7d1c3aa1cb42f4306535481c009367ffa42c7223 (patch)
tree2b54edae5c5ad86d740b14ddffddd2434a68fdcb
parent8024a2636feb60026a79715430a66bb572b9eae8 (diff)
Minor tidy-ups.
-rw-r--r--IkiWiki/Plugin/git.pm7
-rw-r--r--IkiWiki/Plugin/recentchanges.pm3
2 files changed, 3 insertions, 7 deletions
diff --git a/IkiWiki/Plugin/git.pm b/IkiWiki/Plugin/git.pm
index 46fa7d2e0..457975d95 100644
--- a/IkiWiki/Plugin/git.pm
+++ b/IkiWiki/Plugin/git.pm
@@ -840,7 +840,7 @@ sub rcs_receive () {
sub rcs_preprevert (@) {
# Determine what the effects are of reverting the patch with the
# ID given by 'rev'. Returns the same structure as rcs_receive.
- # FIXME note test_changes expects 'cgi' and 'session' parameters.
+ # Note test_changes expects 'cgi' and 'session' parameters.
my %params = @_;
my $rev = $params{rev};
@@ -870,10 +870,7 @@ sub rcs_showpatch (@) {
my %params = @_;
my $rev = $params{rev};
- # FIXME check
- my @r = run_or_die('git', 'show', $rev);
-
- return join "\n", @r;
+ return join "\n", run_or_die('git', 'show', $rev);
}
1
diff --git a/IkiWiki/Plugin/recentchanges.pm b/IkiWiki/Plugin/recentchanges.pm
index 4a8d1bf80..9a62cb243 100644
--- a/IkiWiki/Plugin/recentchanges.pm
+++ b/IkiWiki/Plugin/recentchanges.pm
@@ -107,12 +107,11 @@ sub sessioncgi ($$) {
IkiWiki::enable_commit_hook();
if($r) {
- die "FIXME revert '$rev' failed.";
+ die "Revert '$rev' failed.";
} else {
require IkiWiki::Render;
IkiWiki::refresh();
IkiWiki::saveindex();
- # FIXME indicate success.
}
} else {
$form->title(sprintf(gettext("confirm reversion of %s"), $rev));