summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorintrigeri <intrigeri@boum.org>2010-12-22 17:49:17 +0100
committerintrigeri <intrigeri@boum.org>2010-12-22 17:51:48 +0100
commit724f29373613518a75c653bbc695848d2f83f47b (patch)
tree026900b330f982af3a42ca3e1d73ed8bbd174d64
parent2d86cba6a2d5916eea3a143f482ce483cb570a38 (diff)
More complicated than expected :/
-rw-r--r--doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn22
1 files changed, 20 insertions, 2 deletions
diff --git a/doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn b/doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn
index 920180dcd..1d163d300 100644
--- a/doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn
+++ b/doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn
@@ -18,7 +18,25 @@ Here is a simple patch for that:
Thanks.
-> I fixed this patch and applied in my po branch, thanks.
-> (This is commit 406485917, please pull.) --[[intrigeri]]
+> I fixed this patch a bit and applied it to my po branch, thanks
+> (commit 406485917).
+>
+> But... a bug (probably in HTML::Template) prevents this
+> theoretically correct solution to actually work.
+> Setting a parameter that does not appear in the template, such as
+> `title_overridden`, is not working on my install: the value does not
+> seem to be stored anywhere, and when accessing it later using
+> `$template->param('title_overridden')` it is always undef.
+> Adding `<TMPL_IF TMPL_VAR TITLE_OVERRIDDEN></TMPL_IF>` in
+> `page.tmpl` is a working, but ugly workaround.
+>
+> I am nevertheless in favour of merging the fix into ikiwiki.
+> We'll then need to find how to find the remaining (smaller) bug so
+> that this code can actually work.
+>
+> I'd like others to test my po branch and see if they can reproduce
+> the bug I am talking of.
+>
+> --[[intrigeri]]
>> Commit 406485917 looks fine to me, FWIW --[[smcv]]