summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorhttp://kerravonsen.dreamwidth.org/ <http://kerravonsen.dreamwidth.org/@web>2010-11-15 02:01:21 +0000
committerJoey Hess <joey@kitenet.net>2010-11-15 02:01:21 +0000
commit608cef54d63ba60efd24ae14012dda7ff8d014a9 (patch)
treed5d27965faf9c8adbbc7f0a5c98b3c6a1f131bad
parent9d26a72468fad69d633875b4ffb4aff8abd80023 (diff)
theory about differences in speed of memoize and non-memoize patches
-rw-r--r--doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn2
1 files changed, 2 insertions, 0 deletions
diff --git a/doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn b/doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn
index c4d3a8ecb..43571ead7 100644
--- a/doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn
+++ b/doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn
@@ -20,6 +20,8 @@ Here's my patch - please consider it! -- [[KathrynAndersen]]
>>>> is less verbose than Kathryn's patch but also not as
>>>> fast; I'm not sure why, tbh. --[[smcv]]
+>>>>> I think it's because my patch focuses on match_glob while the memoize patch focuses on `glob2re`, and `glob2re` is called in `filecheck`, `meta` and `po` as well as in `match_glob` and `match_user`; thus the memoized `glob2re` is dealing with a bigger set of globs to look up, and thus could be just that little bit slower. -- [[KathrynAndersen]]
+
--------------------------------------------------------------
Benchmarks done with Devel::Profile on the same testbed IkiWiki setup. I'm just showing the start of the profile output, since that's what's relevant.