diff options
| author | W. Trevor King <wking@drexel.edu> | 2011-02-22 08:46:07 -0500 |
|---|---|---|
| committer | W. Trevor King <wking@drexel.edu> | 2011-02-22 10:00:28 -0500 |
| commit | 5e6e3b90604adb6bbafd6aab19f62014fecc558b (patch) | |
| tree | 17f045ea4eed0a4f7a3247634ae43c0b73afff71 | |
| parent | c0dc26b3c8142743f488978abf11666a10b2f212 (diff) | |
Respond to Joey's most recent inline_raw_files comments.
| -rw-r--r-- | doc/todo/inline_raw_files.mdwn | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/doc/todo/inline_raw_files.mdwn b/doc/todo/inline_raw_files.mdwn index ef7fcb12c..50119b19d 100644 --- a/doc/todo/inline_raw_files.mdwn +++ b/doc/todo/inline_raw_files.mdwn @@ -88,3 +88,24 @@ which seems likely. Or, another way to do it would be to use the templates plugin, and make a template there that puts an inline directive inside pre tags. --[[Joey]] [[!tag reviewed]] + +---- + +If `pagetype()` cannot fail, then I suppose that check has to go ;). + +I was under the impression that [[plugins/highlight]] didn't support +inlining code. It looks like it supports highlighing stand-alone +files or embedded code. Perhaps I should extend it to support inlined +code instead of pushing this patch? + +The `raw.tmpl` included in the patch *does* include the inlined +content inside `pre` tags. The problem is that the current inline +code insists on running `htmlize()` on the content before inserting it +in the template. The heart of my patch is an altered +`get_inline_content()` that makes the `htmlize()` call dependent on a +`$read_raw` flag. If the flag is set, the raw (non-htmlized) content +is used instead. + +I just rebased my patches against the current Ikiwiki trunk (no major +changes) to make them easier to review. + --[[wtk]] |