diff options
| author | http://www.cse.unsw.edu.au/~willu/ <http://www.cse.unsw.edu.au/~willu/@web> | 2009-05-22 02:30:58 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2009-05-22 02:30:58 -0400 |
| commit | 5b2945cc921b222b07415ebea0c0d699f2a9dace (patch) | |
| tree | b1b875d6a30cf97dbfb565e71533cc0d5182e9e9 | |
| parent | 47cff6eda61701a6142b40b93991fd9a84f065c4 (diff) | |
response
| -rw-r--r-- | doc/todo/tracking_bugs_with_dependencies.mdwn | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/doc/todo/tracking_bugs_with_dependencies.mdwn b/doc/todo/tracking_bugs_with_dependencies.mdwn index 04d5f2ba0..707790a75 100644 --- a/doc/todo/tracking_bugs_with_dependencies.mdwn +++ b/doc/todo/tracking_bugs_with_dependencies.mdwn @@ -307,6 +307,9 @@ account all comments above (which doesn't mean it is above reproach :) ). --[[W >>> But if a plugin adds its own match function, it has >>> to explicitly call that code to support named pagespecs. +>>>> Yes, and it can do that in just three lines of code. But if we automatically check for named pagespecs all the time we +>>>> potentially break any matching function that doesn't accept pages, or wants to use multiple arguments. + > * I need to check if your trick to avoid infinite recursion > works if there are two named specs that recursively > call one-another. I suspect it does, but will test this @@ -433,7 +436,7 @@ Patch updated to use closures rather than inline generated code for named pagesp - \w+\([^\)]*\) # command(params) + define\(\s*~\w+\s*,((\([^()]*\)) | ([^()]+))+\) # define(~specName, spec) - spec can contain parens 1 deep + | - + \w+\([^())]*\) # command(params) - params cannot contain parens + + \w+\([^()]*\) # command(params) - params cannot contain parens | [^\s()]+ # any other text ) |