summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorintrigeri <intrigeri@boum.org>2011-04-04 02:01:05 +0200
committerintrigeri <intrigeri@boum.org>2011-04-04 02:01:05 +0200
commit2cbd5a1bdaa029606408ae06de2ee7d1e276328c (patch)
tree39d46691257444602adb7e44577630aefee44cf1
parent1ff51b84e079458a5ab2d0f5c80944bd8325e8f3 (diff)
Researched a bit the internal/external links styling todo item.
-rw-r--r--doc/todo/CSS_classes_for_links.mdwn16
1 files changed, 16 insertions, 0 deletions
diff --git a/doc/todo/CSS_classes_for_links.mdwn b/doc/todo/CSS_classes_for_links.mdwn
index 38db87724..8abe49827 100644
--- a/doc/todo/CSS_classes_for_links.mdwn
+++ b/doc/todo/CSS_classes_for_links.mdwn
@@ -101,3 +101,19 @@ I find CSS3 support still spotty... Here are some notes on how to do this in Ik
>>>
>>> `htmllink` can never be used to generate an external link. So,
>>> patching it seems the best approach. --[[Joey]]
+
+>>>> I had a quick look to this issue. Internal links are generated at
+>>>> 11 places in the Perl code and would need to be patched (this
+>>>> number could be lowered a bit if a htmllink-like function existed
+>>>> for CGI urls; such a function would use `cgiurl`, and be used in
+>>>> most places where `cgiurl` is currently called by plugins).
+>>>>
+>>>> Also, more than 30 `<a>` links appear in templates, most of those
+>>>> being internal links.
+>>>>
+>>>> Sure, patching those few dozen places is trivial. On the other
+>>>> hand, I'm wondering how doable it would be to make sure, on the
+>>>> long run, any generated internal link has the right CSS class
+>>>> applied. One would need to write tests running against the code
+>>>> with all plugins enabled, all templates put to work, in order to
+>>>> ensure consistency is maintained. --[[intrigeri]]