summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2009-03-27 15:51:13 -0400
committerJoey Hess <joey@gnu.kitenet.net>2009-03-27 15:51:13 -0400
commit2852cf14a2b2b6610ea1d4c64f3bb9741b494ae1 (patch)
treef7d82210d811f687ca3d968db63e1b80d43fc749
parentc8237b4351f6023b3d3a661df2568c6d7488b8cf (diff)
review
-rw-r--r--doc/plugins/contrib/po.mdwn11
-rw-r--r--doc/todo/need_global_renamepage_hook.mdwn4
2 files changed, 15 insertions, 0 deletions
diff --git a/doc/plugins/contrib/po.mdwn b/doc/plugins/contrib/po.mdwn
index c39008466..a5e3375ce 100644
--- a/doc/plugins/contrib/po.mdwn
+++ b/doc/plugins/contrib/po.mdwn
@@ -328,3 +328,14 @@ but the po thing is supposed to work without these ugly `our`.
Seems like it was the last unaddressed item from Joey's review, so I'm
daring a timid "please pull"... or rather, please review again :)
--[[intrigeri]]
+
+> Ok, I've reviewed and merged into my own po branch. It's looking very
+> mergeable. I would still like to go over the `po.pm` code in detail and
+> review it, but it's very complex, and I'm happy with all the changes
+> outside `po.pm`.
+>
+> * Is it worth trying to fix compatability with `indexpages`?
+> * Would it make sense to go ahead and modify `page.tmpl` to use
+> OTHERLANGUAGES and PERCENTTRANSLATED, instead of documenting how to modify it?
+>
+> --[[Joey]]
diff --git a/doc/todo/need_global_renamepage_hook.mdwn b/doc/todo/need_global_renamepage_hook.mdwn
index 69655f2e9..b065c82f3 100644
--- a/doc/todo/need_global_renamepage_hook.mdwn
+++ b/doc/todo/need_global_renamepage_hook.mdwn
@@ -107,3 +107,7 @@ hashes is desired, it could return the full set of hashes.
>>> I've implemented this nice solution in my po branch, please review.
>>> I'm slowly coming back to do the last bits needed to get my po and
>>> meta branch merged. --[[intrigeri]]
+
+>>>> It looks good. I made some small changes to it in my own po branch.
+>>>> Nothing significant really. If this were not tied up in the po branch,
+>>>> I've have merged it to master already. --[[Joey]]