diff options
| author | Joey Hess <joey@kitenet.net> | 2008-06-22 09:42:08 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2008-06-22 09:42:08 -0400 |
| commit | 27daf1ad140c79a8512f927c4a03fa74ff53173b (patch) | |
| tree | 07aa712054c9b28a7251af2f3674d51c986d7c05 | |
| parent | 899c319191c8f82b03f7d67f3feeeae437423e2f (diff) | |
web commit by http://willu.myopenid.com/: Some info on tracking down the remaining issue
| -rw-r--r-- | doc/todo/require_CAPTCHA_to_edit.mdwn | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/doc/todo/require_CAPTCHA_to_edit.mdwn b/doc/todo/require_CAPTCHA_to_edit.mdwn index 0e32afc65..d87c73260 100644 --- a/doc/todo/require_CAPTCHA_to_edit.mdwn +++ b/doc/todo/require_CAPTCHA_to_edit.mdwn @@ -30,7 +30,20 @@ A second issue is that the OpenID login system resets the 'required' flags of all the other fields, so using OpenID will cause the CAPTCHA to be ignored. -> This is still a todo. +> This is still not fixed. I would have thought the following patch would +> have fixed this second issue, but it doesn't. + +--- a/IkiWiki/Plugin/openid.pm ++++ b/IkiWiki/Plugin/openid.pm +@@ -61,6 +61,7 @@ sub formbuilder_setup (@) { #{{{ + # Skip all other required fields in this case. + foreach my $field ($form->field) { + next if $field eq "openid_url"; ++ next if $field eq "recaptcha"; + $form->field(name => $field, required => 0, + validate => '/.*/'); + } + Instructions ===== |