diff options
| author | Joey Hess <joey@kodama.kitenet.net> | 2008-07-23 14:58:39 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kodama.kitenet.net> | 2008-07-23 14:58:39 -0400 |
| commit | 1d1767192c80548755655cfe1ce8e503b392c7c1 (patch) | |
| tree | ec27a26e9eba1929e1d379371064d3c0cc6d9ccb | |
| parent | eca900e65934d89ba48c9055eb05482ac0d590fd (diff) | |
attachment: Do not escape _ when determining attachment filenames.
| -rw-r--r-- | IkiWiki/Plugin/attachment.pm | 2 | ||||
| -rw-r--r-- | debian/changelog | 1 | ||||
| -rw-r--r-- | doc/bugs/attachment:_escaping_underscores_in_filename__63__.mdwn | 2 |
3 files changed, 4 insertions, 1 deletions
diff --git a/IkiWiki/Plugin/attachment.pm b/IkiWiki/Plugin/attachment.pm index 01d0d2478..3982c4883 100644 --- a/IkiWiki/Plugin/attachment.pm +++ b/IkiWiki/Plugin/attachment.pm @@ -102,7 +102,7 @@ sub formbuilder (@) { #{{{ } } - $filename=IkiWiki::titlepage( + $filename=IkiWiki::linkpage( IkiWiki::possibly_foolish_untaint( attachment_location($form->field('page')). IkiWiki::basename($filename))); diff --git a/debian/changelog b/debian/changelog index 7ab18a2c7..c699f698b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -11,6 +11,7 @@ ikiwiki (2.55) UNRELEASED; urgency=low * Add allow_symlinks_before_srcdir config setting that can be used to avoid a security check that is a good safe default, but problimatic overkill in some situations. + * attachment: Do not escape _ when determining attachment filenames. -- Joey Hess <joeyh@debian.org> Mon, 21 Jul 2008 11:35:46 -0400 diff --git a/doc/bugs/attachment:_escaping_underscores_in_filename__63__.mdwn b/doc/bugs/attachment:_escaping_underscores_in_filename__63__.mdwn index 509edd3fa..d7d101700 100644 --- a/doc/bugs/attachment:_escaping_underscores_in_filename__63__.mdwn +++ b/doc/bugs/attachment:_escaping_underscores_in_filename__63__.mdwn @@ -15,3 +15,5 @@ Is it a bug or security feature? --[[Paweł|ptecza]] >> and `myisam__95__vs__95__ndb.ods` files. When I click "Attachments" link, >> I can't see my uploaded files, because there are in another subdirectory >> (`myisam__95__vs__95__ndb` instead of `myisam_vs_ndb`). --[[Paweł|ptecza]] + +> [[done]], uses `linkpage` now. |