summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2010-04-02 16:41:04 -0400
committerJoey Hess <joey@gnu.kitenet.net>2010-04-02 16:41:04 -0400
commit1c8ac7d88c5a3d2c63892737e54be8a1b535936c (patch)
treef8d5444f925dfab7cd95e18b6830d694c700ec3d
parent104919ee07b70b166c6c6be13b4f6e5bc5225179 (diff)
review from the woods
-rw-r--r--doc/todo/matching_different_kinds_of_links.mdwn19
1 files changed, 19 insertions, 0 deletions
diff --git a/doc/todo/matching_different_kinds_of_links.mdwn b/doc/todo/matching_different_kinds_of_links.mdwn
index 0049281fe..20acdde49 100644
--- a/doc/todo/matching_different_kinds_of_links.mdwn
+++ b/doc/todo/matching_different_kinds_of_links.mdwn
@@ -96,3 +96,22 @@ Ordinary [[WikiLinks|ikiwiki/WikiLink]] appear in `%links`, but not in
An optional third parameter sets the link type (`undef` produces an ordinary
[[ikiwiki/WikiLink]]).
+
+> Some code refers to `oldtypedlinks`, and other to `oldlinktypes`.
+>
+> I'm curious what your reasoning was for adding a new variable
+> rather than using `pagestate`. Was it only because you needed
+> the `old` version to detect change, or was there other complexity?
+>
+> I have not convinced myself this is a real problem, but..
+> If a page has a typed link, there seems to be no way to tell
+> if it also has a separate, regular link. `add_link` will add
+> to `@links` when adding a typed, or untyped link. If only untyped
+> links were recorded there, one could tell the difference. But then
+> typed links would not show up at all in eg, a linkmap,
+> unless it was changed to check for typed links too.
+> (Or, regular links could be recorded in typedlinks too,
+> with a empty type. (Bloaty.))
+>
+> I suspect we could get away without having `tagged_is_strict`
+> without too much transitional trouble. --[[Joey]]