diff options
| author | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2006-12-18 16:11:51 +0000 |
|---|---|---|
| committer | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2006-12-18 16:11:51 +0000 |
| commit | 02c41e9eb15fb1bb1e6d3c3013f81da67a0e1204 (patch) | |
| tree | f00575346cede8085f4a54843185c715dece2389 | |
| parent | 93e86f654fd8f7f98121452affd38b226f87588a (diff) | |
use POST
| -rw-r--r-- | IkiWiki/Plugin/poll.pm | 3 | ||||
| -rw-r--r-- | doc/bugs/poll_plugin_uses_GET.mdwn | 4 | ||||
| -rw-r--r-- | doc/news/openid.mdwn | 2 |
3 files changed, 6 insertions, 3 deletions
diff --git a/IkiWiki/Plugin/poll.pm b/IkiWiki/Plugin/poll.pm index 654d46247..c040deb76 100644 --- a/IkiWiki/Plugin/poll.pm +++ b/IkiWiki/Plugin/poll.pm @@ -45,7 +45,8 @@ sub preprocess (@) { #{{{ my $ret=""; foreach my $choice (@choices) { if ($open && exists $config{cgiurl}) { - $ret.="<form action=\"$config{cgiurl}\">\n"; + # use POST to avoid robots + $ret.="<form method=\"POST\" action=\"$config{cgiurl}\">\n"; } my $percent=$total > 0 ? int($choices{$choice} / $total * 100) : 0; $ret.="<p>\n"; diff --git a/doc/bugs/poll_plugin_uses_GET.mdwn b/doc/bugs/poll_plugin_uses_GET.mdwn index adf51159a..0538aaa93 100644 --- a/doc/bugs/poll_plugin_uses_GET.mdwn +++ b/doc/bugs/poll_plugin_uses_GET.mdwn @@ -3,4 +3,6 @@ The [[plugins/poll]] plugin uses GET for the vote links. As a result, the done -- [[Joey]] -Not quite; [the `<form>` `method` attribute defaults to GET](http://www.w3.org/TR/html401/interact/forms.html#adef-method). The forms each need the attribute `method="POST"`.
\ No newline at end of file +Not quite; [the `<form>` `method` attribute defaults to GET](http://www.w3.org/TR/html401/interact/forms.html#adef-method). The forms each need the attribute `method="POST"`. + +[[bugs/done]] -- [[Joey]] diff --git a/doc/news/openid.mdwn b/doc/news/openid.mdwn index cf813dfa1..f9ae0b3c9 100644 --- a/doc/news/openid.mdwn +++ b/doc/news/openid.mdwn @@ -10,4 +10,4 @@ log back in, try out the OpenID signup process if you don't already have an OpenID, and see how OpenID works for you. And let me know your feelings about making such a switch. --[[Joey]] -[[poll 10 "Accept only OpenID for logins" 6 "Accept only password logins" 8 "Accept both"]] +[[poll 9 "Accept only OpenID for logins" 5 "Accept only password logins" 7 "Accept both"]] |