summaryrefslogtreecommitdiff
path: root/doc/bugs/httpauth_conflicts_with_git_anon_push.mdwn
blob: 91507f57a34d3ea12aaa0c20666ecda461b86abf (plain)

Someone tried to report a bug using IRC while I was on vacation. --[[Joey]]

Analysis:

  • IkiWiki::Receive calls check_canedit.
  • httpauth's canedit hook returns an error handler function which redirects the browser through the cgiauthurl. (Similarly, signinedit's hook may call needsignin, which can display a signin form.
  • That doesn't work well when doing a git anon push. :)
  • Also, IkiWiki::Receive calls check_canattach and check_canremove, which both also call check_canedit.

So, all these calls need to avoid running the error handler functions returned by canedit hooks, and just return error messages. [[done]] --[[Joey]]