diff options
| author | https://www.google.com/accounts/o8/id?id=AItOawlnFkgzrv6n4UuYWXv8APZiG8_ydyMOyR4 <Timo@web> | 2011-04-30 18:55:09 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2011-04-30 18:55:09 -0400 |
| commit | 1ea8f4cf4d9483f11eff019db8cd1bd287088ab6 (patch) | |
| tree | 6a382b870a089a87f02fbcdcb84b1e7aed467ce2 | |
| parent | 029a6b72e72d0c4da8c3ef95e42a8d8caae6687f (diff) | |
added a comment on my lovely patch
| -rw-r--r-- | doc/todo/nested_preprocessor_directives.mdwn | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/doc/todo/nested_preprocessor_directives.mdwn b/doc/todo/nested_preprocessor_directives.mdwn index 3094e0899..079981054 100644 --- a/doc/todo/nested_preprocessor_directives.mdwn +++ b/doc/todo/nested_preprocessor_directives.mdwn @@ -46,3 +46,13 @@ nesting, a new syntax would be needed. Maybe something xml-like? >> >> Also, the patch seems incomplete, only patching the first regexp >> but not the other two in the same function, which also are quoting-aware. --[[Joey]] +>> +>> Yes, I'm terribly sorry. I actually did edit the other two regexps, but +>> I apparently missed copying it over as well. Should have been doing this +>> in a git repo all along. Look at the new commit I put atop it that has +>> the rest as well: +>> <https://github.com/timo/ikiwiki/commit/a4e33d9654404acff71344cd5d3672bcdf3f3ce5> +>> Also: I'm not sure any more, why I added the m modifier. It was very +>> late at night and I was getting a bit desperate (turned out, the next +>> morning, I put my extra regexes after the "unquoted value" one. heh.) +>> So, feel free to fix that. --Timo |