From 12f30bbed9bb66ea561298259e42a198195235fc Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sun, 5 Apr 2009 17:59:08 -0700 Subject: use /usr/bin/env to call perl in keytrans shebang. --- src/share/keytrans | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/share/keytrans') diff --git a/src/share/keytrans b/src/share/keytrans index 8b2e2ea..d9830f4 100755 --- a/src/share/keytrans +++ b/src/share/keytrans @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w -T +#!/usr/bin/env perl -w -T # keytrans: this is an RSA key translation utility; it is capable of # transforming RSA keys (both public keys and secret keys) between -- cgit v1.2.3 From ae60b830b1a1354acd458a1cf593bd92bd8e8a00 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sun, 5 Apr 2009 19:38:35 -0700 Subject: undo perl shebang line change i just made, since the '-w -T' options don't seem to work with /usr/bin/env --- src/share/keytrans | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/share/keytrans') diff --git a/src/share/keytrans b/src/share/keytrans index d9830f4..8b2e2ea 100755 --- a/src/share/keytrans +++ b/src/share/keytrans @@ -1,4 +1,4 @@ -#!/usr/bin/env perl -w -T +#!/usr/bin/perl -w -T # keytrans: this is an RSA key translation utility; it is capable of # transforming RSA keys (both public keys and secret keys) between -- cgit v1.2.3 From 5df09d935f33477cdd9763c0e9c1ba7c8073aea0 Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Mon, 6 Apr 2009 21:09:12 -0400 Subject: more portable perl-based simple_checksum; i think this is correct, but i welcome any pointers about what i might be getting wrong. --- src/share/keytrans | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/share/keytrans') diff --git a/src/share/keytrans b/src/share/keytrans index 8b2e2ea..e6777ff 100755 --- a/src/share/keytrans +++ b/src/share/keytrans @@ -195,11 +195,11 @@ my $keyserver_prefs = { nomodify => 0x80 ########### Math/Utility Functions ############## -# see the bottom of page 43 of RFC 4880 +# see the bottom of page 44 of RFC 4880 (http://tools.ietf.org/html/rfc4880#page-44) sub simple_checksum { my $bytes = shift; - return unpack("%32W*",$bytes) % 65536; + return unpack("%16C*",$bytes); } # calculate the multiplicative inverse of a mod b this is euclid's -- cgit v1.2.3 From c9b8f4f7a781431e4586cfe3e6afc7f2a6b0a2d5 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Mon, 6 Apr 2009 19:52:34 -0700 Subject: remove -w from keytrans shebang line, since it's redundant with 'use warnings' --- src/share/keytrans | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/share/keytrans') diff --git a/src/share/keytrans b/src/share/keytrans index e6777ff..f9288fa 100755 --- a/src/share/keytrans +++ b/src/share/keytrans @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w -T +#!/usr/bin/perl -T # keytrans: this is an RSA key translation utility; it is capable of # transforming RSA keys (both public keys and secret keys) between -- cgit v1.2.3