From da4eaf98b33ae5acd3280f4fa4dbe023997135dd Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Mon, 23 Jun 2008 18:53:20 -0400 Subject: Add trap to remove lockfiles on exit. --- src/common | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/common b/src/common index 9dcc5e8..1908022 100644 --- a/src/common +++ b/src/common @@ -445,6 +445,9 @@ update_known_hosts() { # least one host returnCode=0 + # set the trap to remove any lockfiles on exit + trap "lockfile-remove $KNOWN_HOSTS" EXIT + # create a lockfile on known_hosts lockfile-create "$KNOWN_HOSTS" @@ -526,6 +529,9 @@ update_authorized_keys() { # at least one user ID returnCode=0 + # set the trap to remove any lockfiles on exit + trap "lockfile-remove $AUTHORIZED_KEYS" EXIT + # create a lockfile on authorized_keys lockfile-create "$AUTHORIZED_KEYS" -- cgit v1.2.3 From 70cf71b1d716e2ec16fae03cd89da3f088f5f4c4 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Mon, 23 Jun 2008 18:57:50 -0400 Subject: Revert to simpler keyserver checking policy in proxy-command. --- src/monkeysphere-ssh-proxycommand | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/monkeysphere-ssh-proxycommand b/src/monkeysphere-ssh-proxycommand index f4d4b0d..6dcb723 100755 --- a/src/monkeysphere-ssh-proxycommand +++ b/src/monkeysphere-ssh-proxycommand @@ -31,6 +31,8 @@ fi HOST="$1" PORT="$2" +MS_HOME=${MS_HOME:-"${HOME}/.config/monkeysphere"} + if [ -z "$HOST" ] ; then log "host must be specified." usage @@ -58,11 +60,12 @@ else # FIXME: this only works for default known_hosts location hostKey=$(ssh-keygen -F "$HOST") if [ "$hostKey" ] ; then - # if the check keyserver variable is NOT set to true... - if [ "$CHECK_KEYSERVER" != 'true' ] ; then - # schedule a keyserver check for host at a later time - echo "monkeysphere update-known_hosts $HOST" | at noon - fi + # do not check the keyserver + # FIXME: more nuanced checking should be done here to properly + # take into consideration hosts that join monkeysphere by + # converting an existing and known ssh key + CHECK_KEYSERVER="false" + # if the host key is not found in the known_hosts file... else # check the keyserver -- cgit v1.2.3 From 9f64c356556520185325d20a8293ffa839c712bf Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Mon, 23 Jun 2008 19:42:21 -0400 Subject: don't unnecessarily export ERR --- src/monkeysphere | 1 - src/monkeysphere-server | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/monkeysphere b/src/monkeysphere index 1368a80..11254e7 100755 --- a/src/monkeysphere +++ b/src/monkeysphere @@ -26,7 +26,6 @@ GREP_OPTIONS= # default return code ERR=0 -export ERR ######################################################################## # FUNCTIONS diff --git a/src/monkeysphere-server b/src/monkeysphere-server index e099a74..369555c 100755 --- a/src/monkeysphere-server +++ b/src/monkeysphere-server @@ -21,7 +21,7 @@ DATE=$(date -u '+%FT%T') # unset some environment variables that could screw things up GREP_OPTIONS= -# assuming other problems don't crop up, we'll return 0 as success +# default return code ERR=0 ######################################################################## -- cgit v1.2.3