From 39b02cf337b2ce0e54d7c045e01eb9931162ba03 Mon Sep 17 00:00:00 2001 From: Jonas Smedegaard Date: Fri, 13 Nov 2020 01:07:10 +0100 Subject: fix revive support for locally overridden variables, and quoting of singular SENDERFILTER --- mailman/mklist.pl | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mailman/mklist.pl b/mailman/mklist.pl index 7893ad7..d0f2549 100755 --- a/mailman/mklist.pl +++ b/mailman/mklist.pl @@ -4,7 +4,7 @@ use warnings; -our ($listname, $listdesc, $listhost, $senders, $senderfilter, $listowner, $moderators); +our ($listname, $listdesc, $listhost, $senders, $senderfilter, $senderfilters, $listowner, $listowners, $moderator, $moderators); # Load optional config my $config_file_addon_org = "/etc/local-ORG/mailman/mklist.conf"; @@ -15,15 +15,15 @@ if ( -f $config_file_addon_org ) { warn "Ignoring non-existing file $config_file_addon_org"; } -$listname = $ENV{'LISTNAME'} or die "LISTNAME missing"; -$listdesc = $ENV{'LISTDESC'} or die "LISTDESC missing"; -$listhost = $ENV{'LISTHOST'} or die "LISTHOST missing"; -$senders = $ENV{'SENDERS'} or die "SENDERS missing"; -$senderfilters = $ENV{'SENDERFILTER'} || $ENV{'SENDERFILTERS'} || '' +$listname ||= $ENV{'LISTNAME'} or die "LISTNAME missing"; +$listdesc ||= $ENV{'LISTDESC'} or die "LISTDESC missing"; +$listhost ||= $ENV{'LISTHOST'} or die "LISTHOST missing"; +$senders ||= $ENV{'SENDERS'} or die "SENDERS missing"; +$senderfilters ||= $ENV{'SENDERFILTERS'} || "'$senderfilter'" || "'$ENV{'SENDERFILTER'}'" || '' or warn "Ignoring missing SENDERFILTER(S)"; -$listowners = $ENV{'LISTOWNERS'} || "'$ENV{'LISTOWNER'}'" +$listowners ||= $ENV{'LISTOWNERS'} || "'$listowner'" || "'$ENV{'LISTOWNER'}'" or die "LISTOWNER(S) missing"; -$moderators = $ENV{'MODERATORS'} || "'$ENV{'MODERATOR'}'"; +$moderators ||= $ENV{'MODERATORS'} || "'$moderator'" || "'$ENV{'MODERATOR'}'"; while (<>) { # Replace keywords - except in comments -- cgit v1.2.3