Removed the underscore from valid login names since it was causing regex errors.

Fixed the system so that the db upgrade script works.
Added some new tasks, notes, etc to TODO.


git-svn-id: https://ledger-smb.svn.sourceforge.net/svnroot/ledger-smb/trunk@21 4979c152-3d1c-0410-bac9-87ea11338e46

5 files changed, 18 insertions, 11 deletions

diff --git a/LedgerSMB/Form.pm b/LedgerSMB/Form.pm
index 73d9f4c5..12ddfa40 100755
--- a/LedgerSMB/Form.pm
+++ b/LedgerSMB/Form.pm
@@ -43,7 +43,7 @@ sub new {
 	$self->{menubar} = 1 if $self->{path} =~ /lynx/i;
 
 	$self->{version} = "2.6.17";
-	$self->{dbversion} = "2.6.12";
+	$self->{dbversion} = "2.6.17";
 
 	bless $self, $type;
 
diff --git a/LedgerSMB/Session.pm b/LedgerSMB/Session.pm
index 902e67c4..d287d199 100755
--- a/LedgerSMB/Session.pm
+++ b/LedgerSMB/Session.pm
@@ -53,7 +53,7 @@ sub session_check {
 		my ($sessionLogin) = $checkQuery->fetchrow_array;
 
 		my $login = $form->{login};
-		$login =~ s/[^a-zA-Z0-9@_.-]//g;
+		$login =~ s/[^a-zA-Z0-9@.-]//g;
 
 		if($sessionLogin eq $login){
 			$updateAge->execute($sessionid) || $form->dberror('Updating session age: ');
@@ -94,7 +94,7 @@ sub session_create {
 	# this is assuming that $form->{login} is safe, which might be a bad assumption
 	# so, I'm going to remove some chars, which might make previously valid logins invalid
 	my $login = $form->{login};
-	$login =~ s/[^a-zA-Z0-9@._-]//g;
+	$login =~ s/[^a-zA-Z0-9@.-]//g;
 
 	#delete any existing stale sessions with this login if they exist
 	if (!$myconfig{timeout}){
diff --git a/TODO b/TODO
index 50341113..be89f07d 100644
--- a/TODO
+++ b/TODO
@@ -16,41 +16,47 @@ Near immediate items (release-delaying?).  * indicates completed.
 - write upgrade/crossgrade script from SL -> LedgerSMB (mostly done)
 	Database script is done.  Just untar over the top?
 	If so, then this is done.
-- write press release
+- *write press release
 - *write SL List announcement
-- SPI membership (Just time the request to Josh for proposal)
 - *CONTRIBUTORS/AUTHORS file.
 - Delete setup.pl file for released versions. (not in SVN).
 - Run final tests on applications
   - crossgrade script-- missing SL directory unlink logic.
   - *templates
-  - db upgrade (not working)
+  - *db upgrade 
 - *Fix printing bug with LaTeX templates.  Error:
 	Quantifier follows nothing in regex; 
 	marked by <-- HERE in m/? <-- HERE / at LedgerSMB/Form.pm line 1107.
 
 Higher priorities
+- Move all other floats to NUMERICs in the database schemas.
 - update setup.pl, which has a lot of SL specific code.
 - make utf-8 default
 - Add protection against duplicate id values. 
+    Chris Travers has a fix that will be applied in the next version but will
+    require some extensive testing.
+- Batch printing of Checks
+    Chris Travers has done this work for another customer for 2.6.15 and can 
+    move this code over quickly.
 - Prevent printing without posting. 
 - Add last cost field to laber/overhead creation screen.
 - drop Oracle support? (ibidem)
     Oracle support is already largely abandoned.  Not sure if we should
-    the code though...
+    drop the code though...
 - code cleanup (move to established coding standards, not structural yet)
 - xhtml compliant code
-- attract developers/documentation
 - central default database (maybe authentication abstraction here?)
 - Integrate a sales data report.
-- Batch printing for cheques.
+    Available as a diff at http://www.metatrontech.com/projects/
 - Bundle script for generating email reports when parts are low.
+    To be included in next version.  Work is already done.
 - Fix reconcilliation summary report.
 - Remove Dieter's sessionid timestamp since it serves no purpose.
 - authentication abstraction for Kerberos, LDAP authentication, and the like.
 - Authentication module for PostgreSQL databases.
 - Account transactions available from Balance Sheets and Income Statements via 
 links.
+- Replace the defaults table with one that is more normalized.
 
 Medium-longer term
 - Port SL-POS functionality into the fork.
@@ -68,3 +74,4 @@ Medium-longer term
   a separate Perl module.
 - Convert to use persistant database connections.
 - Basic payroll module
+- Multiple Shipto's associated with customers/vendors.
diff --git a/doc/release_notes b/doc/release_notes
index 8809ce0a..88371732 100644
--- a/doc/release_notes
+++ b/doc/release_notes
@@ -14,7 +14,7 @@ time.
 
 2.1: Login name restrictions
 Logins in SQL-Ledger can contain any printable characters.  In LedgerSMB these
-are restricted to alphanumeric characters and the symbols ., @, _, and -.
+are restricted to alphanumeric characters and the symbols ., @, and -.
 
 2.2: Session handling
 SQL-Ledger as of 2.6.17 uses session tokens for authentication.  These tokens
diff --git a/sql/Pg-tables.sql b/sql/Pg-tables.sql
index 36adf684..3f9b2a24 100755
--- a/sql/Pg-tables.sql
+++ b/sql/Pg-tables.sql
@@ -70,7 +70,7 @@ CREATE TABLE defaults (
   glnumber text,
   projectnumber text
 );
-INSERT INTO defaults (version) VALUES ('2.6.12');
+INSERT INTO defaults (version) VALUES ('2.6.17');
 --
 CREATE TABLE acc_trans (
   trans_id int,