Merge branch 'ikiwiki'HEADmaster

Conflicts (resolved manually):
	IkiWiki/Plugin/img.pm
	IkiWiki/Plugin/osm.pm

2 files changed, 71 insertions, 67 deletions

diff --git a/IkiWiki/Plugin/img.pm b/IkiWiki/Plugin/img.pm
index d31febf..9f9c72c 100644
--- a/IkiWiki/Plugin/img.pm
+++ b/IkiWiki/Plugin/img.pm
@@ -67,6 +67,12 @@ sub preprocess (@) {
 	my $issvg = $base=~s/\.svg$/.png/i;
 	my $usegm = 1;
 
+	my $ispdf = $base=~s/\.pdf$/.png/i;
+	my $pagenumber = exists($params{pagenumber}) ? int($params{pagenumber}) : 0;
+	if ($pagenumber != 0) {
+		$base = "p$pagenumber-$base";
+	}
+
 	eval q{use Graphics::Magick};
 	if ($@) {
 		$usegm = 0;
@@ -77,77 +83,79 @@ sub preprocess (@) {
 		? Graphics::Magick->new($issvg ? (magick => "png") : ())
 		: Image::Magick->new($issvg ? (magick => "png") : ());
 	my $imglink;
-	my $r = $im->Read($srcfile);
+	my $imgdatalink;
+	my $r = $im->Read("$srcfile\[$pagenumber]");
 	error sprintf(gettext("failed to read %s: %s"), $file, $r) if $r;
-	
+
+	if (! defined $im->Get("width") || ! defined $im->Get("height")) {
+		error sprintf(gettext("failed to get dimensions of %s"), $file);
+	}
+
 	my ($dwidth, $dheight);
 
-	if ($params{size} ne 'full') {
+	if ($params{size} eq 'full') {
+		$dwidth = $im->Get("width");
+		$dheight = $im->Get("height");
+	} else {
 		my ($w, $h) = ($params{size} =~ /^(\d*)x(\d*)$/);
 		error sprintf(gettext('wrong size format "%s" (should be WxH)'), $params{size})
 			unless (defined $w && defined $h &&
 			        (length $w || length $h));
-		
-		if ((length $w && $w > $im->Get("width")) ||
-		    (length $h && $h > $im->Get("height"))) {
-		    	# resizing larger
-			$imglink = $file;
-
-			# don't generate larger image, just set display size
-			if (length $w && length $h) {
-				($dwidth, $dheight)=($w, $h);
-			}
-			# avoid division by zero on 0x0 image
-			elsif ($im->Get("width") == 0 || $im->Get("height") == 0) {
-				($dwidth, $dheight)=(0, 0);
-			}
-			# calculate unspecified size from the other one, preserving
-			# aspect ratio
-			elsif (length $w) {
-				$dwidth=$w;
-				$dheight=$w / $im->Get("width") * $im->Get("height");
-			}
-			elsif (length $h) {
-				$dheight=$h;
-				$dwidth=$h / $im->Get("height") * $im->Get("width");
-			}
+
+		if ($im->Get("width") == 0 || $im->Get("height") == 0) {
+			($dwidth, $dheight)=(0, 0);
+		} elsif (! length $w || (length $h && $im->Get("height")*$w > $h * $im->Get("width"))) {
+			# using height because only height is given or ...
+			# because original image is more portrait than $w/$h
+			# ... slimness of $im > $h/w
+			# ... $im->Get("height")/$im->Get("width") > $h/$w
+			# ... $im->Get("height")*$w > $h * $im->Get("width")
+
+			$dheight=$h;
+			$dwidth=$h / $im->Get("height") * $im->Get("width");
+		} else { # (! length $h) or $w is what determines the resized size
+			$dwidth=$w;
+			$dheight=$w / $im->Get("width") * $im->Get("height");
+		}
+	}
+
+	if ($dwidth < $im->Get("width") || $ispdf) {
+		# resize down, or resize to pixels at all
+
+		my $outfile = "$config{destdir}/$dir/$params{size}-$base";
+		$imglink = "$dir/$params{size}-$base";
+
+		will_render($params{page}, $imglink);
+
+		if (-e $outfile && (-M $srcfile >= -M $outfile)) {
+			$im = $usegm ? Graphics::Magick->new : Image::Magick->new;
+			$r = $im->Read($outfile);
+			error sprintf(gettext("failed to read %s: %s"), $outfile, $r) if $r;
 		}
 		else {
-			# resizing smaller
-			my $outfile = "$config{destdir}/$dir/${w}x${h}-$base";
-			$imglink = "$dir/${w}x${h}-$base";
-		
-			will_render($params{page}, $imglink);
-
-			if (-e $outfile && (-M $srcfile >= -M $outfile)) {
-				$im = $usegm ? Graphics::Magick->new : Image::Magick->new;
-				$r = $im->Read($outfile);
-				error sprintf(gettext("failed to read %s: %s"), $outfile, $r) if $r;
+			$r = $im->Resize(geometry => "${dwidth}x${dheight}");
+			error sprintf(gettext("failed to resize: %s"), $r) if $r;
+
+			$im->set(($issvg || $ispdf) ? (magick => 'png') : ());
+			my @blob = $im->ImageToBlob();
+			# don't actually write resized file in preview mode;
+			# rely on width and height settings
+			if (! $params{preview}) {
+				writefile($imglink, $config{destdir}, $blob[0], 1);
 			}
 			else {
-				$r = $im->Resize(geometry => "${w}x${h}");
-				error sprintf(gettext("failed to resize: %s"), $r) if $r;
-
-				# don't actually write resized file in preview mode;
-				# rely on width and height settings
-				if (! $params{preview}) {
-					my @blob = $im->ImageToBlob();
-					writefile($imglink, $config{destdir}, $blob[0], 1);
-				}
-				else {
-					$imglink = $file;
-				}
+				eval q{use MIME::Base64};
+				error($@) if $@;
+				$imgdatalink = "data:image/".$im->Get("magick").";base64,".encode_base64($blob[0]);
 			}
-
-			# always get the true size of the resized image
-			$dwidth  = $im->Get("width"); 
-			$dheight = $im->Get("height");
 		}
-	}
-	else {
-		$imglink = $file;
-		$dwidth = $im->Get("width");
+
+		# always get the true size of the resized image (it could be
+		# that imagemagick did its calculations differently)
+		$dwidth  = $im->Get("width");
 		$dheight = $im->Get("height");
+	} else {
+		$imglink = $file;
 	}
 	
 	if (! defined($dwidth) || ! defined($dheight)) {
@@ -155,14 +163,9 @@ sub preprocess (@) {
 	}
 
 	my ($fileurl, $imgurl);
-	if (! $params{preview}) {
-		$fileurl=urlto($file, $params{destpage});
-		$imgurl=urlto($imglink, $params{destpage});
-	}
-	else {
-		$fileurl=urlto($file);
-		$imgurl=urlto($imglink);
-	}
+	my $urltobase = $params{preview} ? undef : $params{destpage};
+	$fileurl=urlto($file, $urltobase);
+	$imgurl=$imgdatalink ? $imgdatalink : urlto($imglink, $urltobase);
 
 	if (! exists $params{class}) {
 		$params{class}="img";
diff --git a/IkiWiki/Plugin/osm.pm b/IkiWiki/Plugin/osm.pm
index c7078ca..e6707d4 100644
--- a/IkiWiki/Plugin/osm.pm
+++ b/IkiWiki/Plugin/osm.pm
@@ -534,7 +534,7 @@ sub include_javascript ($) {
 		}
 	}
 	if ($loader) {
-		return embed_map_code($page) . "<script type=\"text/javascript\" charset=\"utf-8\">$loader</script>";
+		return embed_map_code($page) . "<script type=\"text/javascript\">$loader</script>";
 	}
 	else {
         	return '';
@@ -561,7 +561,7 @@ sub cgi($) {
 	print "<html><body>";
 	print "<div id=\"mapdiv-$map\"></div>";
 	print embed_map_code();
-	print "<script type=\"text/javascript\" charset=\"utf-8\">";
+	print "<script type=\"text/javascript\">";
 	print map_setup_code($map, $map,
 		lat => "urlParams['lat']",
 		lon => "urlParams['lon']",
@@ -629,6 +629,7 @@ sub map_setup_code($;@) {
 	}
         $options{'layers'} = $config{osm_layers};
 
+	$name=~s/'//g; # $name comes from user input
 	return "mapsetup('mapdiv-$name', " . to_json(\%options) . ");";
 }