summaryrefslogtreecommitdiff
path: root/doc/patchqueue/more_class__61____34____34___for_css.mdwn
blob: 4b77a3ebf167dece5fea880cb8bdc5935fcae960 (plain)

I'm writing my own CSS for ikiwiki. During this effort I often found the need of adding more class="" attributes to the default ikiwiki templates. This way more presentational aspects of visual formatting can be delegated to CSS and removed from the HTML structure.

In this patch I plan to collect changes in this direction.

The first, one-liner, patch is to use a "div" element with a class="actions" attribute for inline page as is done with non-inlined page. This way the same CSS formatting can be applied to div.actions in the CSS, while at the moment it must be duplicated for a span.actions (which I believe is also incorrect, since it will contain a "ul" element, not sure though). In case the markup should be differentiated it will still be possible relying on the fact that a div.actions is contained or not in a div.inlinepage.

Here's the one-liner:

--- /usr/share/ikiwiki/templates/inlinepage.tmpl        2006-12-28 16:24:06.000000000 +0100
+++ inlinepage.tmpl.new 2006-12-28 16:24:04.000000000 +0100
@@ -31,7 +31,7 @@
 </span>

 <TMPL_IF NAME="HAVE_ACTIONS">
-<span class="actions">
+<div class="actions">
 <ul>
 <TMPL_IF NAME="EDITURL">
 <li><a href="<TMPL_VAR EDITURL>">Edit</a></li>
@@ -40,7 +40,7 @@
 <li><TMPL_VAR DISCUSSIONLINK></li>
 </TMPL_IF>
 </ul>
-</span>
+</div>
 </TMPL_IF>

 </div>

The following adds a div element with class="trailer" around the meta-information added after an inlined page (namely: the post date, the tags, and the actions):

--- inlinepage.tmpl.orig        2006-12-28 16:56:49.000000000 +0100
+++ inlinepage.tmpl     2006-12-28 17:02:06.000000000 +0100
@@ -17,6 +17,8 @@
 </span>
 <TMPL_VAR CONTENT>

+<div class="trailer">
+
 <span class="pageinfo">
 Posted <TMPL_VAR CTIME>
 </span>
@@ -44,3 +46,5 @@
 </TMPL_IF>

 </div>
+
+</div>