summaryrefslogtreecommitdiff
path: root/doc/bugs/Please_avoid_using___39__cp_-a__39___in_Makefile.PL.mdwn
blob: 97ea61883ecc15d957e8b46b743a95017320dc58 (plain)

In ikiwiki-2.60, external plug-ins are yet again installed using 'cp -a' instead of 'install -m 755'. This poses a problem on at least FreeBSD 6.x, since the cp(1) command doesn't support the '-a' flag.

The change in question (from 2.56 to 2.60) can be seen here:

-       for file in `find plugins -maxdepth 1 -type f ! -wholename plugins/.\*`; do \
-               install -m 755 $$file $(DESTDIR)$(PREFIX)/lib/ikiwiki/plugins; \
-       done; \
+       for file in `find plugins -maxdepth 1 -type f ! -wholename plugins/.\* | grep -v demo`; do \
+               cp -a $$file $(DESTDIR)$(PREFIX)/lib/ikiwiki/plugins; \
+       done \

Please restore the old behaviour of using 'install' :-)

-- [[HenrikBrixAndersen]]

I use cp -a because I don't want non-executable files to be installed executable. (Causes breakage with setup file creation code) I really wish *BSD could get out of the 70's in this area.. --[[Joey]]