The graphviz.pm plug-in currently attempts to read PNG data in UTF-8 mode, which sometimes fail with a message similar to the following (depending on the input):

    utf8 "\x89" does not map to Unicode at /usr/local/lib/perl5/site_perl/5.8.8/IkiWiki/Plugin/graphviz.pm line 53, <IN> chunk 1.
    Wide character in subroutine entry at /usr/local/lib/perl5/site_perl/5.8.8/IkiWiki/Plugin/graphviz.pm line 68.

> Ok, will remove the binmode IN then. done --[[Joey]]

>> Thanks --[[HenrikBrixAndersen]]

It also generates image URLs relative to the page being rendered, which means the URLs wont work when previewing a graph from the CGI script.

(preview bug split to [[Problems_with_graphviz.pm_plug-in_previews]])

>> Here is an updated patch againt ikiwiki-2.5:

>>> [[Applied|done]], thanks. --[[Joey]]

The patch below fixes these two issues.

    --- graphviz.pm.orig	Thu Jun  7 15:45:16 2007
    +++ graphviz.pm	Fri Jun  8 12:03:38 2007
    @@ -41,7 +41,6 @@ sub render_graph (\%) {
     		$pid=open2(*IN, *OUT, "$params{prog} -Tpng");
     
     		# open2 doesn't respect "use open ':utf8'"
    -		binmode (IN, ':utf8');
     		binmode (OUT, ':utf8');
     
     		print OUT $src;
    @@ -70,7 +69,12 @@ sub render_graph (\%) {
     		}
     	}
     
    -	return "<img src=\"".urlto($dest, $params{page})."\" />\n";
    +	if ($params{preview}) {
    +		return "<img src=\"".urlto($dest, "")."\" />\n";
    +	}
    +	else {
    +		return "<img src=\"".urlto($dest, $params{page})."\" />\n";
    +	}
     }
     
     sub graph (@) {
91208000001.ACE571CE0AC@lxp5.free-owl.de/sys?h=master'>commit</a><a href='/notmuch/diff/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys?h=master'>diff</a></td><td class='form'><form class='right' method='get' action='/notmuch/log/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys'>
<input type='hidden' name='h' value='master'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/notmuch/commit/?h=master'>root</a>/<a href='/notmuch/commit/tags?h=master'>tags</a>/<a href='/notmuch/commit/tags/02?h=master'>02</a>/<a href='/notmuch/commit/tags/02/fb?h=master'>fb</a>/<a href='/notmuch/commit/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de?h=master'>20191208000001.ACE571CE0AC@lxp5.free-owl.de</a>/<a href='/notmuch/commit/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys?h=master'>sys</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='h' value='master'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Jonas Smedegaard &lt;dr@jones.dk&gt;</td><td class='right'>2023-06-27 09:35:08 +0200</td></tr>
<tr><th>committer</th><td>Jonas Smedegaard &lt;dr@jones.dk&gt;</td><td class='right'>2023-06-27 09:35:08 +0200</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/notmuch/commit/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys?h=master&amp;id=fd54908da2b05c526dd3bee9b6dcd093214a220d'>fd54908da2b05c526dd3bee9b6dcd093214a220d</a> (<a href='/notmuch/patch/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys?id=fd54908da2b05c526dd3bee9b6dcd093214a220d'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/notmuch/tree/?h=master'>c69c845069c99d1d01044f6fafda7c08433329c6</a> /<a href='/notmuch/tree/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys?h=master'>tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/notmuch/commit/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys?h=master&amp;id=ba46132213560cf3335d53560d519c0ec0190da2'>ba46132213560cf3335d53560d519c0ec0190da2</a> (<a href='/notmuch/diff/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys?h=master&amp;id2=ba46132213560cf3335d53560d519c0ec0190da2'>diff</a>)</td></tr></table>
<div class='commit-subject'><span class='decoration'><a class='branch-deco' href='/notmuch/log/tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys?h=master'>master</a></span></div><div class='commit-msg'></div><div class='diffstat-header'><a href='/notmuch/diff/?h=master'>Diffstat</a> (limited to 'tags/02/fb/20191208000001.ACE571CE0AC@lxp5.free-owl.de/sys')</div><table summary='diffstat' class='diffstat'>