From e63ead1c13290f314579f90e8ae2a607f2b69e7a Mon Sep 17 00:00:00 2001 From: intrigeri Date: Tue, 29 Jun 2010 15:50:19 +0200 Subject: please review new po pagespec: needstranlation() --- doc/todo/po_needstranslation_pagespec.mdwn | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 doc/todo/po_needstranslation_pagespec.mdwn (limited to 'doc/todo') diff --git a/doc/todo/po_needstranslation_pagespec.mdwn b/doc/todo/po_needstranslation_pagespec.mdwn new file mode 100644 index 000000000..acc5641a4 --- /dev/null +++ b/doc/todo/po_needstranslation_pagespec.mdwn @@ -0,0 +1,5 @@ +Commit b225fdc44d4b3d in my po branch adds a `needstranslation()` +PageSpec. It makes it easy to list pages that need translation work. +Please review. --[[intrigeri]] + +[[!tag patch]] -- cgit v1.2.3 From 8a8914151cee44592dfdc3df3bb2c45b19b8c29c Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 4 Jul 2010 14:22:19 -0400 Subject: review of needstranslation() pagespec Minor wording fix; changelog; etc. --- IkiWiki/Plugin/po.pm | 2 +- debian/changelog | 1 + doc/todo/po_needstranslation_pagespec.mdwn | 6 +++++- 3 files changed, 7 insertions(+), 2 deletions(-) (limited to 'doc/todo') diff --git a/IkiWiki/Plugin/po.pm b/IkiWiki/Plugin/po.pm index f12c69d5f..0b2251668 100644 --- a/IkiWiki/Plugin/po.pm +++ b/IkiWiki/Plugin/po.pm @@ -1225,7 +1225,7 @@ sub match_needstranslation ($$;@) { my $percenttranslated=IkiWiki::Plugin::po::percenttranslated($page); if ($percenttranslated eq 'N/A') { - return IkiWiki::FailReason->new("file is not a translation page"); + return IkiWiki::FailReason->new("file is not a translatable page"); } elsif ($percenttranslated < 100) { return IkiWiki::SuccessReason->new("file has $percenttranslated translated"); diff --git a/debian/changelog b/debian/changelog index 7d857d9c0..bdcf52884 100644 --- a/debian/changelog +++ b/debian/changelog @@ -20,6 +20,7 @@ ikiwiki (3.20100624) UNRELEASED; urgency=low * git: Added git_wrapper_background_command option. Can be used to eg, make the git wrapper push to github in the background after ikiwiki runs. + * po: Added needstranslation() pagespec. (intrigeri) -- Joey Hess Wed, 23 Jun 2010 15:30:04 -0400 diff --git a/doc/todo/po_needstranslation_pagespec.mdwn b/doc/todo/po_needstranslation_pagespec.mdwn index acc5641a4..77449dc2b 100644 --- a/doc/todo/po_needstranslation_pagespec.mdwn +++ b/doc/todo/po_needstranslation_pagespec.mdwn @@ -2,4 +2,8 @@ Commit b225fdc44d4b3d in my po branch adds a `needstranslation()` PageSpec. It makes it easy to list pages that need translation work. Please review. --[[intrigeri]] -[[!tag patch]] +> Looks good, cherry-picked. The only improvment I can +> think of is that `needstranslation(50)` could match +> only pages less than 50% translated. --[[Joey]] + +[[!tag patch done]] -- cgit v1.2.3 From beabd511e2477b90c409ce63c3b8decb5769ef03 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 4 Jul 2010 15:23:59 -0400 Subject: comment --- doc/todo/Fix_selflink_in_po_plugin.mdwn | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/Fix_selflink_in_po_plugin.mdwn b/doc/todo/Fix_selflink_in_po_plugin.mdwn index b83d2814a..791c6c055 100644 --- a/doc/todo/Fix_selflink_in_po_plugin.mdwn +++ b/doc/todo/Fix_selflink_in_po_plugin.mdwn @@ -8,3 +8,9 @@ Fixed in my po branch. --[[intrigeri]] [[!tag patch]] > bump? + +>> I know I've looked at 88c6e2891593fd508701d728602515e47284180c +>> before, and something about it just seemed wrong. Maybe it's +>> the triviality of the sub, which it would seem to be easy to +>> decide to refactor back into its one caller (which would reintroduce the +>> bug). --[[Joey]] -- cgit v1.2.3