From 2b12f7de26eed4741bcd1b05223ae56586f8c835 Mon Sep 17 00:00:00 2001 From: "http://www.cse.unsw.edu.au/~willu/" Date: Sat, 9 Aug 2008 06:56:36 -0400 Subject: Add a suggestion --- doc/todo/progressbar_plugin.mdwn | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/progressbar_plugin.mdwn b/doc/todo/progressbar_plugin.mdwn index d586ce79c..34769ca7b 100644 --- a/doc/todo/progressbar_plugin.mdwn +++ b/doc/todo/progressbar_plugin.mdwn @@ -42,3 +42,11 @@ You can use alternative, commented CSS code for `div.progress` if you dislike padding around done strip. Any comments? --[[Paweł|ptecza]] + +> This looks like a nice idea. If I could add one further suggestion: Allow your +> ratio to be a pair of pagespecs. Then you could have something like: + + \[[!progress totalpages="bugs/* and backlink(milestoneB)" donepages="bugs/* and backlink(milestoneB) and !link(bugs/done)"]] + +> to have a progress bar marking how many bugs were compete for a +> particular milestone. -- [[Will]] -- cgit v1.2.3 From 907f717bce78d9c08f67475d309f51b0675af288 Mon Sep 17 00:00:00 2001 From: "http://www.cse.unsw.edu.au/~willu/" Date: Sat, 9 Aug 2008 07:05:44 -0400 Subject: --- doc/todo/anti-spam_protection.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/anti-spam_protection.mdwn b/doc/todo/anti-spam_protection.mdwn index 7c2994cb9..cb45faee5 100644 --- a/doc/todo/anti-spam_protection.mdwn +++ b/doc/todo/anti-spam_protection.mdwn @@ -15,3 +15,5 @@ Cheers, >> Mh.. well. I know this problem, too. I leave the Discussion sites open for no registrations, so that visitors can easily write a comment to this specific blog entry without the need for registration. (This would be the same behaviour, as many blogging engines are using). Maybe it is possible to wrote a plugin that would scan the text which is submitted via spamassassin or something similar. (Using this combined with known spam URLs would maybe reduce the load of the server if there are many webpages which are getting editted by someone). If you like this idea Joey I might be interested to write such a plugin after my exams this and the next month. :) -- [[Winnie]] You might look at the Wikipedia page on "Spam\_in\_blogs" for more ideas. In particular, would it be possible to force a subset of the pages (by regex, but you'd choose the regex to match those pages which are publicly writable) to use rel="nofollow" in all links. + +> I just wanted to leave a link here to the [[todo/require_CAPTCHA_to_edit]] plugin patch. Unfortunately that plugin currently interacts badly with the openid plugin. -- [[Will]] -- cgit v1.2.3 From 146c3b98cd969e2d7844b898b7d8312f486970cd Mon Sep 17 00:00:00 2001 From: "http://www.cse.unsw.edu.au/~willu/" Date: Sat, 9 Aug 2008 07:27:48 -0400 Subject: Add thoughts on bug numbers --- doc/todo/Better_bug_tracking_support.mdwn | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'doc/todo') diff --git a/doc/todo/Better_bug_tracking_support.mdwn b/doc/todo/Better_bug_tracking_support.mdwn index 0559078e0..628a67fc8 100644 --- a/doc/todo/Better_bug_tracking_support.mdwn +++ b/doc/todo/Better_bug_tracking_support.mdwn @@ -20,7 +20,17 @@ be embedded to the source code repository commit messages. > I sorta take your point about bug numbers. It can be a pain to refer to > 'using_a_wiki_for_issue_tracking' as a bug name in a place like a > changelog. -> + +>> Would a modified [[plugins/inline]] plugin that allowed new pages, but without a title field, be ok? +>> When you hit the edit button it just chooses a new number and makes a page with that +>> name. + +>> The only issue I can see with this is if you're using a distributed wiki for +>> distributed bug tracking. In that case you're going to have to make sure that you +>> don't get conflicting bug ids. +>> Maybe there should be two options - consecutive numbering, and uuid numbering +>> which uses a random (128 bit, base64 encoded = 22 chars) name. -- [[Will]] + > OTOH, I don't see a need for specially formatted commit messages to be > used to close bugs. Instead, if your BTS is kept in an ikiwiki wiki in > an RCS along with your project, you can do like I do here, and just edit a -- cgit v1.2.3 From 0eab8e9e67e963502a359f298f14eb919272f56f Mon Sep 17 00:00:00 2001 From: "http://www.cse.unsw.edu.au/~willu/" Date: Sat, 9 Aug 2008 08:31:53 -0400 Subject: Add patch --- doc/todo/progressbar_plugin.mdwn | 69 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/progressbar_plugin.mdwn b/doc/todo/progressbar_plugin.mdwn index 34769ca7b..2325d2e40 100644 --- a/doc/todo/progressbar_plugin.mdwn +++ b/doc/todo/progressbar_plugin.mdwn @@ -50,3 +50,72 @@ Any comments? --[[Paweł|ptecza]] > to have a progress bar marking how many bugs were compete for a > particular milestone. -- [[Will]] + +>> Attached is a [[patch]] (well, source) for this. You also need to add the proposed CSS above to `style.css`. +>> At the moment this plugin interacts poorly with the [[plugins/htmlscrubber]] plugin. +>> HTMLScrubber plugin removes the `style` attribute from the `progress-done` `div` tag, and so it defaults +>> to a width of 100%. -- [[Will]] + + #!/usr/bin/perl + package IkiWiki::Plugin::progress; + + use warnings; + use strict; + use IkiWiki 2.00; + + my $percentage_pattern = qr/[0-9]\%/; # pattern to validate percentages + + sub import { #{{{ + hook(type => "getsetup", id => "progress", call => \&getsetup); + hook(type => "preprocess", id => "progress", call => \&preprocess); + } # }}} + + sub getsetup () { #{{{ + return + plugin => { + safe => 1, + rebuild => undef, + }, + } #}}} + + sub preprocess (@) { #{{{ + my %params=@_; + + my $fill; + + if (defined $params{percent}) { + $fill = $params{percent}; + ($fill) = $fill =~ m/($percentage_pattern)/; # fill is untainted now + } + elsif (defined $params{totalpages} and defined $params{donepages}) { + add_depends($params{page}, $params{totalpages}); + add_depends($params{page}, $params{donepages}); + + my @pages=keys %pagesources; + my $totalcount=0; + my $donecount=0; + foreach my $page (@pages) { + $totalcount++ if pagespec_match($page, $params{totalpages}, location => $params{page}); + $donecount++ if pagespec_match($page, $params{donepages}, location => $params{page}); + } + + if ($totalcount == 0) { + $fill = "100%" + } else { + my $number = $donecount/$totalcount*100; + $fill = sprintf("%u%%", $number); + } + } + else { + error("Missing parameters to progress plugin. Need either `percent` or `totalpages` and `donepages` parameters."); + } + + return < +
$fill
+ + EODIV + + } # }}} + + 1 -- cgit v1.2.3 From d89e07c96c4890566e12768191fd5f5f0905cb11 Mon Sep 17 00:00:00 2001 From: "http://www.cse.unsw.edu.au/~willu/" Date: Sat, 9 Aug 2008 08:33:29 -0400 Subject: --- doc/todo/progressbar_plugin.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/todo') diff --git a/doc/todo/progressbar_plugin.mdwn b/doc/todo/progressbar_plugin.mdwn index 2325d2e40..aa066680f 100644 --- a/doc/todo/progressbar_plugin.mdwn +++ b/doc/todo/progressbar_plugin.mdwn @@ -100,7 +100,7 @@ Any comments? --[[Paweł|ptecza]] } if ($totalcount == 0) { - $fill = "100%" + $fill = "100%"; } else { my $number = $donecount/$totalcount*100; $fill = sprintf("%u%%", $number); -- cgit v1.2.3 From 252f8adc2aec18005c8b05bca1a31f73b2c078b8 Mon Sep 17 00:00:00 2001 From: "http://www.cse.unsw.edu.au/~willu/" Date: Sat, 9 Aug 2008 08:35:59 -0400 Subject: --- doc/todo/progressbar_plugin.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/todo') diff --git a/doc/todo/progressbar_plugin.mdwn b/doc/todo/progressbar_plugin.mdwn index aa066680f..19e23a6f0 100644 --- a/doc/todo/progressbar_plugin.mdwn +++ b/doc/todo/progressbar_plugin.mdwn @@ -63,7 +63,7 @@ Any comments? --[[Paweł|ptecza]] use strict; use IkiWiki 2.00; - my $percentage_pattern = qr/[0-9]\%/; # pattern to validate percentages + my $percentage_pattern = qr/[0-9]+\%/; # pattern to validate percentages sub import { #{{{ hook(type => "getsetup", id => "progress", call => \&getsetup); -- cgit v1.2.3 From a303321e5ed7b68e0fce32a2a6fe10d268670a5a Mon Sep 17 00:00:00 2001 From: "http://ptecza.myopenid.com/" Date: Sat, 9 Aug 2008 09:33:59 -0400 Subject: * Response --- doc/todo/progressbar_plugin.mdwn | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/progressbar_plugin.mdwn b/doc/todo/progressbar_plugin.mdwn index 19e23a6f0..d8c0a5cec 100644 --- a/doc/todo/progressbar_plugin.mdwn +++ b/doc/todo/progressbar_plugin.mdwn @@ -51,11 +51,17 @@ Any comments? --[[Paweł|ptecza]] > to have a progress bar marking how many bugs were compete for a > particular milestone. -- [[Will]] +>> Thanks a lot for your comment, Will! It seems very interesting for me. +>> I need to think more about improving that plugin. --[[Paweł|ptecza]] + >> Attached is a [[patch]] (well, source) for this. You also need to add the proposed CSS above to `style.css`. >> At the moment this plugin interacts poorly with the [[plugins/htmlscrubber]] plugin. >> HTMLScrubber plugin removes the `style` attribute from the `progress-done` `div` tag, and so it defaults >> to a width of 100%. -- [[Will]] +>>> Thank you for the code! I know how to fix that problem, because I had +>>> the same issue while writing [[todo/color_plugin]] :) --[[Paweł|ptecza]] + #!/usr/bin/perl package IkiWiki::Plugin::progress; -- cgit v1.2.3 From d3eb0075d300bcfd504dc878e63761dbbc5171be Mon Sep 17 00:00:00 2001 From: "http://ptecza.myopenid.com/" Date: Sat, 9 Aug 2008 09:46:27 -0400 Subject: * Response --- doc/todo/color_plugin.mdwn | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/color_plugin.mdwn b/doc/todo/color_plugin.mdwn index ebf5b084c..3d83bb605 100644 --- a/doc/todo/color_plugin.mdwn +++ b/doc/todo/color_plugin.mdwn @@ -103,6 +103,11 @@ Of course, I'm open for discussion or exchange of ideas :) --[[Paweł|ptecza]] > One question, why the 2px padding for span.color? --[[Joey]] +>> Sorry for a long silence, but I had Internet free summer holiday :) +>> I did that, because backgrounded text without any padding seems +>> strange for me ;) You can remove it if you don't like that padding. +>> --[[Paweł|ptecza]] + --- /dev/null 2008-06-21 02:02:15.000000000 +0200 +++ color.pm 2008-07-27 14:58:12.000000000 +0200 @@ -0,0 +1,69 @@ -- cgit v1.2.3