From 6257a714077712e818127ed0c68d9a9611d7628f Mon Sep 17 00:00:00 2001 From: intrigeri Date: Thu, 7 Jan 2010 23:22:48 +0100 Subject: selflink detection is suboptimal when using the po plugin --- doc/todo/Fix_selflink_in_po_plugin.mdwn | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 doc/todo/Fix_selflink_in_po_plugin.mdwn (limited to 'doc/todo/Fix_selflink_in_po_plugin.mdwn') diff --git a/doc/todo/Fix_selflink_in_po_plugin.mdwn b/doc/todo/Fix_selflink_in_po_plugin.mdwn new file mode 100644 index 000000000..ae59e14c2 --- /dev/null +++ b/doc/todo/Fix_selflink_in_po_plugin.mdwn @@ -0,0 +1,4 @@ +Using the po plugin, a link to /bla is present in the sidebar. +When viewing /bla in the default language, this link is detected as +a selflink. When viewing a translation of /bla, it +isn't. --[[intrigeri]] -- cgit v1.2.3 From cf7d03ec80e168ad18d65a90842773da353ee060 Mon Sep 17 00:00:00 2001 From: intrigeri Date: Sat, 9 Jan 2010 22:57:11 +0100 Subject: fixed bug in my po branch, please pull --- doc/todo/Fix_selflink_in_po_plugin.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo/Fix_selflink_in_po_plugin.mdwn') diff --git a/doc/todo/Fix_selflink_in_po_plugin.mdwn b/doc/todo/Fix_selflink_in_po_plugin.mdwn index ae59e14c2..55968e3d7 100644 --- a/doc/todo/Fix_selflink_in_po_plugin.mdwn +++ b/doc/todo/Fix_selflink_in_po_plugin.mdwn @@ -2,3 +2,5 @@ Using the po plugin, a link to /bla is present in the sidebar. When viewing /bla in the default language, this link is detected as a selflink. When viewing a translation of /bla, it isn't. --[[intrigeri]] + +Fixed in my po branch => [[!tag patch]]. --[[intrigeri]] -- cgit v1.2.3 From 62a67e161bccba431b8b8a501967ba7acf6e197a Mon Sep 17 00:00:00 2001 From: intrigeri Date: Sat, 9 Jan 2010 22:59:46 +0100 Subject: wiki syntax fix --- doc/todo/Fix_selflink_in_po_plugin.mdwn | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'doc/todo/Fix_selflink_in_po_plugin.mdwn') diff --git a/doc/todo/Fix_selflink_in_po_plugin.mdwn b/doc/todo/Fix_selflink_in_po_plugin.mdwn index 55968e3d7..87fa38911 100644 --- a/doc/todo/Fix_selflink_in_po_plugin.mdwn +++ b/doc/todo/Fix_selflink_in_po_plugin.mdwn @@ -3,4 +3,6 @@ When viewing /bla in the default language, this link is detected as a selflink. When viewing a translation of /bla, it isn't. --[[intrigeri]] -Fixed in my po branch => [[!tag patch]]. --[[intrigeri]] +Fixed in my po branch. --[[intrigeri]] + +[[!tag patch]] -- cgit v1.2.3 From 8f266d4d436be5cbb765ac81424687e764397d05 Mon Sep 17 00:00:00 2001 From: intrigeri Date: Fri, 25 Jun 2010 19:32:46 +0200 Subject: another bugreport with patch --- doc/todo/Fix_selflink_in_po_plugin.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo/Fix_selflink_in_po_plugin.mdwn') diff --git a/doc/todo/Fix_selflink_in_po_plugin.mdwn b/doc/todo/Fix_selflink_in_po_plugin.mdwn index 87fa38911..b83d2814a 100644 --- a/doc/todo/Fix_selflink_in_po_plugin.mdwn +++ b/doc/todo/Fix_selflink_in_po_plugin.mdwn @@ -6,3 +6,5 @@ isn't. --[[intrigeri]] Fixed in my po branch. --[[intrigeri]] [[!tag patch]] + +> bump? -- cgit v1.2.3 From beabd511e2477b90c409ce63c3b8decb5769ef03 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 4 Jul 2010 15:23:59 -0400 Subject: comment --- doc/todo/Fix_selflink_in_po_plugin.mdwn | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'doc/todo/Fix_selflink_in_po_plugin.mdwn') diff --git a/doc/todo/Fix_selflink_in_po_plugin.mdwn b/doc/todo/Fix_selflink_in_po_plugin.mdwn index b83d2814a..791c6c055 100644 --- a/doc/todo/Fix_selflink_in_po_plugin.mdwn +++ b/doc/todo/Fix_selflink_in_po_plugin.mdwn @@ -8,3 +8,9 @@ Fixed in my po branch. --[[intrigeri]] [[!tag patch]] > bump? + +>> I know I've looked at 88c6e2891593fd508701d728602515e47284180c +>> before, and something about it just seemed wrong. Maybe it's +>> the triviality of the sub, which it would seem to be easy to +>> decide to refactor back into its one caller (which would reintroduce the +>> bug). --[[Joey]] -- cgit v1.2.3 From 1f4f13ce0b354c0950b5d13d0da32dbfce8880c3 Mon Sep 17 00:00:00 2001 From: intrigeri Date: Sun, 11 Jul 2010 11:37:48 +0200 Subject: reply. and now? --- doc/todo/Fix_selflink_in_po_plugin.mdwn | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'doc/todo/Fix_selflink_in_po_plugin.mdwn') diff --git a/doc/todo/Fix_selflink_in_po_plugin.mdwn b/doc/todo/Fix_selflink_in_po_plugin.mdwn index 791c6c055..c4f6662ce 100644 --- a/doc/todo/Fix_selflink_in_po_plugin.mdwn +++ b/doc/todo/Fix_selflink_in_po_plugin.mdwn @@ -14,3 +14,8 @@ Fixed in my po branch. --[[intrigeri]] >> the triviality of the sub, which it would seem to be easy to >> decide to refactor back into its one caller (which would reintroduce the >> bug). --[[Joey]] + +>>> Well, I can hear and understand this. Apart of adding a comment to +>>> the sub, explaining the rationale (which is now done in my po +>>> branch), I don't know what I can do to make it not seem wrong. +>>> --[[intrigeri]] -- cgit v1.2.3 From def97ec7fe5f84c0d1931ff2c0f8b33b78fed114 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 18 Jul 2010 19:43:25 -0400 Subject: merge fix for selflink po problem --- debian/changelog | 1 + doc/todo/Fix_selflink_in_po_plugin.mdwn | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) (limited to 'doc/todo/Fix_selflink_in_po_plugin.mdwn') diff --git a/debian/changelog b/debian/changelog index b7387a050..db828f580 100644 --- a/debian/changelog +++ b/debian/changelog @@ -21,6 +21,7 @@ ikiwiki (3.20100705) UNRELEASED; urgency=low * Made much more robust in cases where multiple source files produce conflicting files/directories in the destdir. * Updated French program translation from Philippe Batailler. Closes: #589423 + * po: Fix selflink display on tranlsated pages. (intrigeri) -- Joey Hess Mon, 05 Jul 2010 13:59:42 -0400 diff --git a/doc/todo/Fix_selflink_in_po_plugin.mdwn b/doc/todo/Fix_selflink_in_po_plugin.mdwn index c4f6662ce..b276c075d 100644 --- a/doc/todo/Fix_selflink_in_po_plugin.mdwn +++ b/doc/todo/Fix_selflink_in_po_plugin.mdwn @@ -5,7 +5,7 @@ isn't. --[[intrigeri]] Fixed in my po branch. --[[intrigeri]] -[[!tag patch]] +[[!tag patch done]] > bump? -- cgit v1.2.3