From b15f37e9e9e617e049207eca04652a8794e9b1de Mon Sep 17 00:00:00 2001 From: joey Date: Thu, 10 May 2007 18:54:37 +0000 Subject: response --- ...ependency_in_eval_while_running_with_-T_switch.mdwn | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) (limited to 'doc/bugs') diff --git a/doc/bugs/Insecure_dependency_in_eval_while_running_with_-T_switch.mdwn b/doc/bugs/Insecure_dependency_in_eval_while_running_with_-T_switch.mdwn index bed5691f3..befda2a93 100644 --- a/doc/bugs/Insecure_dependency_in_eval_while_running_with_-T_switch.mdwn +++ b/doc/bugs/Insecure_dependency_in_eval_while_running_with_-T_switch.mdwn @@ -67,4 +67,20 @@ because `patch` command fails: Could you please fix that patch? I guess how to do it, but I don't want to break the code I distribute in my backport ;) --- Pawel \ No newline at end of file +-- Pawel + +> It's not my patch.. IIRC my suggestion was simply to do this: --[Joey]] + + Index: IkiWiki.pm + =================================================================== + --- IkiWiki.pm (revision 3565) + +++ IkiWiki.pm (working copy) + @@ -1005,7 +1005,7 @@ + unshift @params, "location"; + } + + - my $ret=eval pagespec_translate($spec); + + my $ret=eval possibly_foolish_untaint(pagespec_translate($spec)); + return IkiWiki::FailReason->new("syntax error") if $@; + return $ret; + } #}}} -- cgit v1.2.3