From a7b8e35bf90fa9e2df8be78ac636b158760ecf9c Mon Sep 17 00:00:00 2001 From: joey Date: Wed, 25 Jul 2007 02:15:52 +0000 Subject: * Fix graphviz plugin to not try to read images as utf-8; they might sometimes contain invalid utf-8 byte sequences. Thanks, HenrikBrixAndersen. --- doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn | 6 ++++++ doc/bugs/hard-coded_location_for_man_pages_and_w3m_cgi_wrapper.mdwn | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) (limited to 'doc/bugs') diff --git a/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn b/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn index 7abf152b9..9eca41faf 100644 --- a/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn +++ b/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn @@ -3,8 +3,14 @@ The graphviz.pm plug-in currently attempts to read PNG data in UTF-8 mode, which utf8 "\x89" does not map to Unicode at /usr/local/lib/perl5/site_perl/5.8.8/IkiWiki/Plugin/graphviz.pm line 53, chunk 1. Wide character in subroutine entry at /usr/local/lib/perl5/site_perl/5.8.8/IkiWiki/Plugin/graphviz.pm line 68. +> Ok, will remove the binmode IN then. [[done]] --[[Joey]] + It also generates image URLs relative to the page being rendered, which means the URLs wont work when previewing a graph from the CGI script. +> You seem to be using an old version of ikiwiki, these preview isues have +> been fixed for some time, and the code doesn't look like what you patch +> in your second hunk. --[[Joey]] + The patch below fixes these two issues. --- graphviz.pm.orig Thu Jun 7 15:45:16 2007 diff --git a/doc/bugs/hard-coded_location_for_man_pages_and_w3m_cgi_wrapper.mdwn b/doc/bugs/hard-coded_location_for_man_pages_and_w3m_cgi_wrapper.mdwn index c8b2151fb..1efa5361f 100644 --- a/doc/bugs/hard-coded_location_for_man_pages_and_w3m_cgi_wrapper.mdwn +++ b/doc/bugs/hard-coded_location_for_man_pages_and_w3m_cgi_wrapper.mdwn @@ -8,6 +8,10 @@ is hard-coded in Makefile.PL. The patch below makes it possible to install those files to alternative directories while the default stays as it is now. +> It should be possible to use the existing MakeMaker variables such as +> INSTALLMAN1DIR (though MakeMaker lacks one for man8). I'd prefer not +> adding new variables where MakeMaker already has them. --[[Joey]] + 
 
   - Introduce two variables, IKI_MANDIR and IKI_W3MCGIDIR, to be set from
@@ -85,4 +89,4 @@ wiki-mass-rebuild.8
  
  WriteMakefile(
 
-
\ No newline at end of file + -- cgit v1.2.3