From f9553a06ab0a13140c62a90a59c566faeedfa9d6 Mon Sep 17 00:00:00 2001 From: "http://smcv.pseudorandom.co.uk/" Date: Fri, 7 May 2010 16:56:45 +0000 Subject: patch --- doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn (limited to 'doc/bugs') diff --git a/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn b/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn new file mode 100644 index 000000000..96bdab9cd --- /dev/null +++ b/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn @@ -0,0 +1,11 @@ +[[!tag patch]] +[[!template id=gitbranch branch=smcv/ready/no-tags author="[[smcv]]"]] + +The `gitremotes` script picks up tags from any repository, including those +used for local .debs that were never actually present in Debian: + + smcv@reptile% git tag | grep -c nmu + 52 + +This can be avoided with the `tagopt = --no-tags` option in .git/config; +see -- cgit v1.2.3 From 5dfcaf1f7f3c2ae8304465bdc10bd82bb862fa09 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 7 May 2010 13:04:00 -0400 Subject: applied --- doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/bugs') diff --git a/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn b/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn index 96bdab9cd..eb37aee1b 100644 --- a/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn +++ b/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn @@ -9,3 +9,5 @@ used for local .debs that were never actually present in Debian: This can be avoided with the `tagopt = --no-tags` option in .git/config; see + +> [[done]] thanks. Also cleared propigated tags out of origin. --[[Joey]] -- cgit v1.2.3 From 888ac35e11a22fe254127f2c39d71909038494c9 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 7 May 2010 13:13:57 -0400 Subject: a bug? --- doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'doc/bugs') diff --git a/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn b/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn index eb37aee1b..32cf419e8 100644 --- a/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn +++ b/doc/bugs/gitremotes_script_picks_up_tags_from_anywhere.mdwn @@ -10,4 +10,9 @@ used for local .debs that were never actually present in Debian: This can be avoided with the `tagopt = --no-tags` option in .git/config; see -> [[done]] thanks. Also cleared propigated tags out of origin. --[[Joey]] +> [[done]] thanks. Also cleared propigated tags out of origin. +> +> Hmm, in testing I still see tags get pulled the first time a remote +> is added. If those are then locally deleted, it doesn't pull them again +> with the `--no-tags`. +> --[[Joey]] -- cgit v1.2.3 From b01a2274c3f96541b8b48f9ebb883ee8b7451fa3 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 7 May 2010 13:25:32 -0400 Subject: fix undef warning when page() tests a deleted file --- IkiWiki.pm | 3 ++- doc/bugs/deletion_warnings.mdwn | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'doc/bugs') diff --git a/IkiWiki.pm b/IkiWiki.pm index 11cfcdfd2..d76b5edb4 100644 --- a/IkiWiki.pm +++ b/IkiWiki.pm @@ -2348,7 +2348,8 @@ sub match_internal ($$;@) { sub match_page ($$;@) { my $page=shift; my $match=match_glob($page, shift, @_); - if ($match && ! defined IkiWiki::pagetype($IkiWiki::pagesources{$page})) { + if ($match && ! (exists $IkiWiki::pagesources{$page} + && defined IkiWiki::pagetype($IkiWiki::pagesources{$page}))) { return IkiWiki::FailReason->new("$page is not a page"); } else { diff --git a/doc/bugs/deletion_warnings.mdwn b/doc/bugs/deletion_warnings.mdwn index c8879379b..668626b49 100644 --- a/doc/bugs/deletion_warnings.mdwn +++ b/doc/bugs/deletion_warnings.mdwn @@ -2,6 +2,9 @@ Seen while deleting a blog's calendar pages: --[[Joey]] +[[done]] -- the new `page()` pagespec needed to check if there was a source +file for the page, and was leaking undef. + 
    427250f..ff6c054  master     -> origin/master
 Use of uninitialized value $file in pattern match (m//) at /usr/share/perl5/IkiWiki.pm line 688.
-- 
cgit v1.2.3